https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1291 Instrument control development <p>The obslog and other consumers need to be able to see active sequences as soon as they have been started, and to see which command/visit_set_id each SPS visit is associated with.</p> <p>sps_sequence.status might need to be handled differently.</p> INSTRM-1291

Create visit_set and sps_sequence rows as soon as practical.

Task Normal Done Done arnaud.lefur cloomis SPS Wed, 16 Jun 2021 18:33:00 +0000 Fri, 25 Jun 2021 15:52:29 +0000 Fri, 25 Jun 2021 15:52:29 +0000 ics_iicActor ics_spsActor 0 2 <p>We need to think a bit to the insert temporality here.<br/> sps_visit and mcs_exposure are inserted when the fits file is actually created which make sense.<br/> For sps_sequence(iic_sequence), visit_set have two options regarding the insert timing:</p> <ul> <li>before the exposure and after gen2 returns getVisit, earliest option. in that case some of the existing constraints would need to be relieved because right now visit_set cannot be inserted before sps_visit, note that <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1305" title="rename sps_sequence to iic_sequence in opdb" class="issue-link" data-issue-key="INSTRM-1305"><del>INSTRM-1305</del></a> raises a similar problem.</li> <li>after the exposure, works with the current schema, but it wouldn't be ideal in the obslog purpose.</li> </ul> <p>dragging <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe" class="user-hover" rel="kiyoto.yabe">Kiyoto Yabe</a> here, because <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1293" title="pull out status column from sps_sequence table" class="issue-link" data-issue-key="INSTRM-1293"><del>INSTRM-1293</del></a> might not be sufficient.</p> <p>I think the constraints might be fine. The sps_sequence creates the new visit_set_id and provides all the command/sequence info, right? So create <b>that</b> before taking any exposures. Each sps exposure will then get a new pfs_visit_id from gen2: when the exposure is done insert the (visit_set_id, pfs_visit_id) row in visit_set. No?</p> <p>Actually, if I'm reading models.py right, the primary key on visit_set should be <tt>sps_sequence.visit_se_id</tt> instead of <tt>sps_visit.pfs_visit_id</tt>.</p> <p>right. In anycase, the join will only be possible when the exposure is finished, but looking at the obslog it might be okay.</p> <p>merged to master</p> Blocks INSTRM-1293 Development Rank 0|02qpuc:i6001gr068fhw9qo4o0m5z Sprint SM1PD-2021 A 12