<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:33:21 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[INSTRM-1242] Add black spot geometry interface</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/INSTRM-1242</link>
                <project id="10300" key="INSTRM">Instrument control development</project>
                    <description>&lt;p&gt;The geometry of the black spots will be added to some pfs_instdata data file. Add a functional interface in pfs_utils.&lt;/p&gt;

&lt;p&gt;This geometry should be in mm in the PFI focal plane.  For each spot we need to know:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;ID (presumably the ID for the cobra that can reach that spot)&lt;/li&gt;
	&lt;li&gt;centre (x, y)&lt;/li&gt;
	&lt;li&gt;radius r1 where the spot starts to shadow the cobra&lt;/li&gt;
	&lt;li&gt;radius r2 where the cobra is fully shadowed&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Initially, we can set r1 and r2 to be the same.&lt;/p&gt;

&lt;p&gt;Additionally, the centre (x, y) is thought to be a function of telescope elevation (we think that it does not depend on the PFI rotation angle).  So we need an API which returns a data structure (say &lt;tt&gt;SpotGeom&lt;/tt&gt;) capturing these parameters, and an API to return either a &lt;br/&gt;
single &lt;tt&gt;SpotGeom&lt;/tt&gt; or a &lt;tt&gt;list&lt;/tt&gt; or &lt;tt&gt;dict&lt;/tt&gt; of &lt;tt&gt;SpotGeom&lt;/tt&gt; for all the spots.  If the ID is a simple integer then the list can be indexed by that integer (with a None for any missing IDs, which is probably only 0).  If we&apos;re using a more complicated name, then return a &lt;tt&gt;dict&lt;/tt&gt;.&lt;/p&gt;</description>
                <environment></environment>
        <key id="15545">INSTRM-1242</key>
            <summary>Add black spot geometry interface</summary>
                <type id="3" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10518&amp;avatarType=issuetype">Task</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="chyan">chyan</assignee>
                                    <reporter username="cloomis">cloomis</reporter>
                        <labels>
                            <label>EngRun</label>
                            <label>PFI</label>
                    </labels>
                <created>Fri, 16 Apr 2021 13:58:04 +0000</created>
                <updated>Wed, 20 Oct 2021 17:48:37 +0000</updated>
                            <resolved>Wed, 20 Oct 2021 17:48:37 +0000</resolved>
                                                                    <component>pfs_utils</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>4</watches>
                                                                <comments>
                            <comment id="21803" author="hassan" created="Fri, 6 Aug 2021 11:48:14 +0000"  >&lt;p&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;Copying from duplicate ticket INSTRM-1339&amp;#93;&lt;/span&gt;: This function should make use (interpolate) the CSV files located here: &lt;a href=&quot;https://github.com/Subaru-PFS/pfs_instdata/blob/master/data/pfi/dot&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://github.com/Subaru-PFS/pfs_instdata/blob/master/data/pfi/dot&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="21806" author="hassan" created="Fri, 6 Aug 2021 13:38:54 +0000"  >&lt;p&gt;&lt;del&gt;Updated description mentions that : &apos;radius r2 where the spot is fully shadowed&apos; Shouldn&apos;t this say &apos;radius r2 where the &lt;em&gt;cobra&lt;/em&gt; is fully shadowed&apos; ?&lt;/del&gt; Done.&lt;/p&gt;</comment>
                            <comment id="22251" author="chyan" created="Tue, 5 Oct 2021 03:20:11 +0000"  >&lt;p&gt;Currently, the dot location is in a file.  There is an implementation using bulter.py package for the IO.  Check line 152 in ics_cobraCharmer/python/ics/cobraCharmer/utils/bulter.py  &lt;/p&gt;</comment>
                            <comment id="22581" author="hassan" created="Fri, 15 Oct 2021 12:06:10 +0000"  >&lt;p&gt;During a ticket review 2021-10-14: need to check with &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis&quot; class=&quot;user-hover&quot; rel=&quot;cloomis&quot;&gt;cloomis&lt;/a&gt; whether all functionality needed for this ticket has been implemented already.&lt;/p&gt;</comment>
                            <comment id="23340" author="chyan" created="Wed, 20 Oct 2021 17:47:39 +0000"  >&lt;p&gt;The dot file is located in &apos;/software/devel/pfs/pfs_instdata/data/pfi/dot/black_dots_mm.csv&apos; and I think this is also agreed by Robert.  So I would close this ticket.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10002">
                    <name>Duplicate</name>
                                                                <inwardlinks description="is duplicated by">
                                        <issuelink>
            <issuekey id="16992">INSTRM-1339</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="15547">INSTRM-1244</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|zzs9uh:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>hassan</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="124">EngRun3Cleanup</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10002" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                        </customfields>
    </item>
</channel>
</rss>