<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:31:25 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[INSTRM-1054] Provide logic for processing SM1 calibration data</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/INSTRM-1054</link>
                <project id="10300" key="INSTRM">Instrument control development</project>
                    <description>&lt;p&gt;In order to process SM1 calibration data (biases, darks dithered flats) through the 2D DRP pipeline using the onsite/offside YAML mechanism being developed by &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=sogo.mineo&quot; class=&quot;user-hover&quot; rel=&quot;sogo.mineo&quot;&gt;sogo.mineo&lt;/a&gt; at NAOJ, we need to implement the logic of identifying the appropriate visits that should be used.&lt;/p&gt;

&lt;p&gt;The agreement so far is to follow the approach &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis&quot; class=&quot;user-hover&quot; rel=&quot;cloomis&quot;&gt;cloomis&lt;/a&gt; posted on the slack #drp-2d channel on 2020-06-10:&lt;/p&gt;
&lt;blockquote&gt;&lt;p&gt;I have been pushing for using the sequence caller ( sequence_type ) and major iic command ( name ),  and requiring that the values for those be made useful for our decisions (e.g. name == &lt;/p&gt;
&lt;div class=&quot;error&quot;&gt;&lt;span class=&quot;error&quot;&gt;Unknown macro: {masterBias, masterDark, ditheredFlat}&lt;/span&gt; &lt;/div&gt;
&lt;p&gt;). I still think that is an OK idea. I think it is better than simply looking at the visit-by-visit progression of the exposure types as they come off the system (bias-bias-bias-dark-arc-object-bias, etc) and deducing what to do.&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;This needs to be elaborated, and implemented in the ICS, and related updates made to the opDB if necessary (which will be subject to a separate, future, ticket).&lt;/p&gt;</description>
                <environment></environment>
        <key id="14671">INSTRM-1054</key>
            <summary>Provide logic for processing SM1 calibration data</summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="arnaud.lefur">arnaud.lefur</assignee>
                                    <reporter username="hassan">hassan</reporter>
                        <labels>
                            <label>SPS</label>
                    </labels>
                <created>Thu, 20 Aug 2020 14:44:10 +0000</created>
                <updated>Wed, 30 Sep 2020 12:52:04 +0000</updated>
                            <resolved>Wed, 30 Sep 2020 12:49:47 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>5</watches>
                                                                <comments>
                            <comment id="17564" author="cloomis" created="Thu, 20 Aug 2020 18:02:21 +0000"  >&lt;p&gt;We have discussed this further and can specify things a bit better.&lt;/p&gt;

&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;&lt;tt&gt;sps_visit.exp_type&lt;/tt&gt; is one of &lt;tt&gt;bias, dark, flat, arc, object, test&lt;/tt&gt;. This is essential information, but is not sufficient to know whether a visit is suitable for any particular purpose. For example, it says nothing about how the lamps are configured.&lt;/li&gt;
&lt;/ul&gt;


&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;&lt;tt&gt;sps_sequence.sequence_type&lt;/tt&gt; does show the purpose behind of a group of exposures, and IIC will set it to known fixed values which can drive reductions. The above values are a good start: &lt;tt&gt;masterBiases, masterDarks, ditheredFlats&lt;/tt&gt;. Data with unrecognized values should be ignored by the calibration and science DRP machinery.&lt;/li&gt;
&lt;/ul&gt;


&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;We will have additional relevant &lt;tt&gt;sequence_type}}s. For instance something like {{fieldCalibs&lt;/tt&gt;, with a flat and one or more arcs to be associated with a particular &lt;tt&gt;pfsConfig&lt;/tt&gt;.&lt;/li&gt;
&lt;/ul&gt;


&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;&lt;tt&gt;sps_annotation.data_flag&lt;/tt&gt; should be checked before using a file, and rows should be be added when bad data are uncovered. I believe that the &lt;em&gt;lack&lt;/em&gt; of &lt;tt&gt;sps_annotation&lt;/tt&gt; rows for a given &lt;tt&gt;(pfs_visit_id, sps_camera_id)&lt;/tt&gt; indicates that the file is assumed to be OK.&lt;/li&gt;
&lt;/ul&gt;



&lt;p&gt;From this, we need an IIC ticket to create the right &lt;tt&gt;sequence_type&lt;/tt&gt; rows.&lt;/p&gt;

&lt;p&gt;And besides this, &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/browse/INSTRM-1026&quot; title=&quot;Add counter for physical SM configuration changes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;INSTRM-1026&quot;&gt;&lt;del&gt;INSTRM-1026&lt;/del&gt;&lt;/a&gt; needs to be made more specific.&lt;/p&gt;</comment>
                            <comment id="17580" author="msyktnk" created="Mon, 24 Aug 2020 04:45:23 +0000"  >&lt;p&gt;This sounds good to me.&#160; Let me just confirm: sps_annotation.data_flag is 0 when the data is bad, correct?&#160; It seems all the entries in the current sps_annotation table has data_flag=0.&#160; If we are going to assume that the lack of entry means that the data is good, we may want to use flag=1 to indicate bad data?&#160; We may even want to change the column name to something like flag_bad_data.&lt;/p&gt;</comment>
                            <comment id="17594" author="hassan" created="Thu, 27 Aug 2020 15:05:50 +0000"  >&lt;p&gt;&lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=msyktnk&quot; class=&quot;user-hover&quot; rel=&quot;msyktnk&quot;&gt;Masayuki Tanaka&lt;/a&gt; following discussions with &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis&quot; class=&quot;user-hover&quot; rel=&quot;cloomis&quot;&gt;cloomis&lt;/a&gt; &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=fmadec&quot; class=&quot;user-hover&quot; rel=&quot;fmadec&quot;&gt;fmadec&lt;/a&gt; and &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=arnaud.lefur&quot; class=&quot;user-hover&quot; rel=&quot;arnaud.lefur&quot;&gt;arnaud.lefur&lt;/a&gt;: a data_flag of &lt;b&gt;0 (zero)&lt;/b&gt; will indicate good data. Non-zero values indicate bad data.&lt;/p&gt;

&lt;p&gt;So all the entries in the current sps_annotation table are &lt;b&gt;good&lt;/b&gt;.&lt;/p&gt;

&lt;p&gt;We all agree with keeping the current name of &lt;tt&gt;data_flag&lt;/tt&gt;.&lt;/p&gt;</comment>
                            <comment id="17595" author="msyktnk" created="Thu, 27 Aug 2020 20:41:37 +0000"  >&lt;p&gt;OK, I misunderstood the meaning of the flag - in an opDB copy at NAOJ, I see comments like &apos;just testing SW&apos; and &apos;FPGA still wrong&apos; in the sps_annotation table, and I naively interpreted the words like &apos;test&apos; and &apos;wrong&apos; as &apos;do not use&apos;.&#160; That is how I misunderstood the flag.&#160; Anyhow, as long as we are clear about the meaning of the flag, we do not need to change anything here.&lt;/p&gt;</comment>
                            <comment id="17810" author="sogo.mineo" created="Tue, 29 Sep 2020 08:01:28 +0000"  >&lt;p&gt;We call &lt;tt&gt;constructPfsBias.py&lt;/tt&gt; with &lt;tt&gt;masterBiases&lt;/tt&gt;,&lt;br/&gt;
&lt;tt&gt;constructPfsDark.py&lt;/tt&gt; with &lt;tt&gt;masterDarks&lt;/tt&gt;,&lt;br/&gt;
&lt;tt&gt;constructFiberFlat.py&lt;/tt&gt; with &lt;tt&gt;ditheredFlats&lt;/tt&gt;.&lt;/p&gt;

&lt;p&gt;I have questions:&lt;/p&gt;

&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;What are the arguments for &lt;tt&gt;bootstrapDetectorMap.py&lt;/tt&gt;&apos;s &lt;tt&gt;&amp;#45;&amp;#45;flatId&lt;/tt&gt; and &lt;tt&gt;&amp;#45;&amp;#45;arcId&lt;/tt&gt; ?&lt;/li&gt;
&lt;/ul&gt;


&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;What are FLAT_ODD and FLAT_EVEN for &lt;tt&gt;constructFiberTrace.py&lt;/tt&gt;?&lt;/li&gt;
&lt;/ul&gt;


&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;With what should we call &lt;tt&gt;reduceArc.py&lt;/tt&gt;? (Maybe &lt;tt&gt;ditheredArcs&lt;/tt&gt;?)&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="17816" author="arnaud.lefur" created="Wed, 30 Sep 2020 12:49:47 +0000"  >&lt;p&gt;implemented an currently running at Subaru.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="14709">INSTRM-1065</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="13573">PIPE2D-423</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="14534">INSTRM-1026</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="14609">INSTRM-1035</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="14610">INSTRM-1036</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|zzs1mg:020wi</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="85">SM1PD-2020 G2</customfieldvalue>
    <customfieldvalue id="86">SM1PD-2020 H</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10002" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                        </customfields>
    </item>
</channel>
</rss>