https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1043 Instrument control development <p>The configuration bits which control which 16-bit window to select from the 18-bit ADC outputs are being misused. The FPGA code for the new (sm2+) ADCs drops support for the old 16-bit ADCs, but the C code which controls both old and new ADCs allows setting the configuration to enable 16-bit support in the old ADCs, and swapped the usage of two of the bits. Not a problem for the new ADCs, but bad for the old ones.</p> <p>A two-line fix plus a comment. Needed for SM1 at Subaru until the ADCs get swapped.</p> INSTRM-1043

Fix usage of ADC bits for old FPGA/ADCs.

Bug Normal Done Done cloomis cloomis SM1 SPS Tue, 28 Jul 2020 16:33:19 +0000 Tue, 28 Jul 2020 21:09:44 +0000 Tue, 28 Jul 2020 21:09:44 +0000 0 1 <p>"Two-line fix" Yes, well.</p> <p>I ended up changing the way ADC versions and modes are tracked, with humans limited to requesting "lsb", "mid", msb" bits, and the CCD object mapping those to the correct FPGA bits. The mapping depends on the FPGA version, which is something which the CCD object knows about. The ADC version cannot be different from the major FPGA version, so we only need to worry about one, which we can read from hardware.</p> <p>This pretty much takes care of a couple of other issues, which I will set to Won't Fix.</p> <p>ics_xcu_fpga: merged at e293a8a, tagged 82.1.1<br/> ics_ccdActor: merged at 8267fea, tagged 1.6.7</p> <p>Both running at Subaru and JHU.</p> Development Rank 0|zzs2bc: