https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1039 Instrument control development <p>Both to be compatible with the eventual <tt>pfilamps</tt> system and to allow taking useful exposures while the SM1 red shutter is stuck open, <tt>iic expose arc</tt> needs to provide exposures where the lamps are turned on and off while the shutter is open.</p> <p>This is valid for all lamps except HgAr.</p> INSTRM-1039

Allow exposures controlled by lamp on/off changes

Task Normal Done Done cloomis cloomis SPS Wed, 15 Jul 2020 16:25:41 +0000 Thu, 13 Aug 2020 16:07:58 +0000 Wed, 5 Aug 2020 15:31:57 +0000 ics_iicActor 0 1 <p>The existing <tt>sps expose arc</tt> command has arguments to <tt>switchOn</tt> lamps and allow for <tt>warmingTime</tt>. I will add per-lamp args which specify the lamp on times, e.g. <tt>qth=15</tt> or <tt>ar=10</tt>, which will be incompatible with the existing args (i.e. if a per-lamp arg is given the <tt>switchOn</tt>, etc. args cannot also be given.)</p> <p>Until the dcb actor is updated to use the setup-then-go command structure of the <tt>pfilamps</tt> I will only allow one lamp.</p> <p>The <tt>expose arc</tt> command creates and "runs" an Arc/Sequence object, which knows about the existing lamp logic. I will instead define and use a different Sequence subclass which uses the "pfilamps" open-then-lamp logic.</p> <p>No matter how completely and correctly we do this, both the <tt>spsActor expose</tt> command and the <tt>dcbActor</tt> lamp control commands and logic will need to changed. </p> <p>I don't think I can do this as anything other than a quick hack.</p> <p>Long comment, mostly so that <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=arnaud.lefur" class="user-hover" rel="arnaud.lefur">arnaud.lefur</a> knows what I have damaged and why.</p> <p><tt>dcbActor</tt> has grown <tt>pflampsActor</tt>-style <tt>prepare neon=S.S halogen=S.S argon=S.S, etc.</tt> and <tt>go delay=SS</tt> commands. The <tt>delay</tt> is a temporary hack to avoid working on the <tt>enuActor shutter</tt> commands for this ticket.</p> <p><tt>iicActor</tt> has grown <tt>arc neon=S.S argon=S.S</tt> and <tt>flat halogen=S.S</tt> variants, which bypass all the <tt>dcbOn</tt> and <tt>dcbOff</tt> parsing and handling. If using the new variants, <tt>iic</tt> arranges to call the <tt>dcb prepare lamps</tt> command, and passes <tt>doLamps</tt> to the <tt>sps expose</tt> commands to get them to change their internal sequences.</p> <p>The <tt>spsActor</tt> <tt>expose arc</tt> and <tt>expose flat</tt> commands have grown a <tt>doLamps</tt> option. If they get that they call <tt>dcb go delay=2</tt> after the detector wipe and before the shutter open command is sent. The disgusting <tt>dcb go delay=SS</tt> hack is used because exposure timing is currently driven by the <tt>enu shutter expose exptime=S.S</tt> command blocking for exptime seconds then closing the shutter. We need to split that so that the <tt>dcb go</tt> can be issued immediately after the shutters have opened.</p> <p>EXPTIME will be the lamp on time; the actual shutter exposure time will be a 4-5 seconds longer.<br/> The lamp cards should be correct. I hope.</p> <p>Am using the existing DCB lamp names (halogen, neon, argon, hgar, krypton) to avoid confusion. Not sure I love them.</p> <p>Please see ticket comments for explanation.</p> <p>Merged and running at Subaru</p> <p>Tags:</p> <ul class="alternate" type="square"> <li>ics_dcbActor 0.0.8</li> <li>ics_iicActor 1.1.6</li> <li>ics_spsActor 1.0.2</li> </ul> Development Rank 0|zzs1mg:09 Reviewers arnaud.lefur Sprint SM1PD-2020 G Story Points 2.0