https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1037 Instrument control development <p>AG cameras position on PFI is needed for "shuffle" to find guide stars.  Following the discussions at ICS/PFI+MCS telecon on 3 and 10 July 2020, 4 corner of each sensor is proper.</p> <p> </p> <p>Hassan, Naoyuki and I talked about the file architecture of this information a while ago, looking the current <tt>pfi.yaml</tt> and Cobra stuffs. To have commonality with Cobra, we'd like to propose:</p> <ul> <li>List available AG cameras in <tt>pfi.yaml</tt> (basically all 6 cameras)</li> <li>Store 4 corners in another .yaml file (1 file for all cameras, or 6 files per camera)</li> </ul> <p> </p> INSTRM-1037

Store AG geometry in pfs_insdata repo

Task Major Done Done Yoshida, Hiroshige yuki.moritani EngRun Fri, 10 Jul 2020 14:38:28 +0000 Fri, 17 Dec 2021 12:35:40 +0000 Mon, 13 Sep 2021 19:11:12 +0000 pfs_instdata 0 5 <p>Since shuffle is required to output pixel coordinates for guide star candidates, the list of four corners is no longer sufficient. To determine this information, we also need to know the "origin" corner, the "+X" and "+Y" corner, and the camera resolution.</p> <p>Alternatively, a per-camera matrix transforming between PFI and the respective pixel coordinate system shold also work well. Then the only additional required information would be the number of pixels in x and y direction.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hiro" class="user-hover" rel="hiro">Yoshida, Hiroshige</a> how do you treat PFI<span class="error">&#91;mm&#93;</span>-AG<span class="error">&#91;pixel&#93;</span> conversion for agActor (and other AG software)? What information do you use?</p> <p>Currently, the AG subsystem implements naive transformation methods internally, using:</p> <ul> <li>reference position of the detectors (center: x = y = 511.5 pix)</li> <li>PFI coordinates of the reference position (r = 241.292 mm, PA = 0, 60, 120, ... deg)</li> <li>rotation angle of the detectors about the reference position (theta = 0, 60, 120, ... deg)</li> <li>detector pixel pitch (p = 13 um)</li> </ul> <p>In general, ignoring distortion, I think we only need, for each AGC:</p> <ul> <li>reference position of the detector (x, y) pix</li> <li>PFI coordinates of the reference position (x, y) mm</li> <li>rotation angle of the detector in PFI coordinates (theta,) deg or rad</li> <li>detector pitch (x, y) um</li> </ul> <p>In stead (or in addition), we could have transformation matrices for each AGC for each direction.</p> <p> </p> <p>Yoshida-san and I talked about this topic. We think it will be nice to have a module to query the PFI position for a AG cameras, and vice versa. In this way, MPA can get PFI coordinates of 4 corners of individual AG cameras, and NAOJ can can get PFI coordinates of observed centroids.. Yoshida-san already has something to do so, so I think his routine should be a good start.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=Martin.Reinecke" class="user-hover" rel="Martin.Reinecke">Martin Reinecke</a> mentioned during the ICS/PFI telecon today that he needs this in order to provide shuffle-related deliveries.</p> <p>The function was implemented, and Martin is now using this function, so I close this ticket.</p> <p>What we may need to modify in the future is to treat the fact that AG pixel coordinates includes overscan region.</p> Relates INFRA-207 FIBERALLOC-29 Development Rank 0|02qpqj:c Story Points 2.0