[INSTRM-1023] Minor FITS edits

Relates — Mon, 29 Jun 2020 19:01:50 +0000

There are a handful of minor FITS errors described in the PFSA01894911_20200619 comments. I plan to fix these all at once.

1) Violation in Value range or Comment part

- DATA-TYP : value 'ARC' is not registered in Subaru FITS rule
- DET-TMP  : unit should be [K] -> needs to fix on the dictionary side?
- ADC-TYP  : Comment 'ADC name' is wrong for the present example 'IN'
             Dictionary requests name of ADC rather than state (such as 'IN')
             but this may need further discussion on the dictionary side (ex. HSC also shows state 'LINK' for this card)
- EXPTIME  : Unit is missing

2) Unregistered keyword (to be registered in Subaru basic keyword dictionary)
- DARKTIME : Unit is also missing

4) Unnecessary keyword that may be better to be removed
- M2-TYPE : existence of M2 may be confusing

5) Wrong keyword name
- ADC-TYP --> ADC-TYPE
- FOC_VAL --> VOC-VAL

8) Others/Misc
- DET-ID : recommended for STARS
- BLANK/ZBLANK :  Subaru rule also needs to define where to put BLANK keyword in the MEF case
                and presumably should require ZBLANK in compressed data

ADC-TYP comes directly from Gen2, so I will leave that alone for now.

So for SPS, should DATA-TYP be one of: BIAS, COMPARISON, DARK, FLAT, OBJECT, and maybe TEST? I think that is all we plan to take. We could add FOCUSING, but I think that will confuse matters.

PFS-JIRA

[INSTRM-1023] Minor FITS edits