https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INFRA-42 Software Development Infrastructure <p>Add the SConscript file from <a href="https://github.com/lsst/templates/blob/master/bin.src/SConscript" class="external-link" rel="nofollow">https://github.com/lsst/templates/blob/master/bin.src/SConscript</a> to bin.src directories of drp_stella and obs_pfs to create the bin executables</p> INFRA-42

Add SConscript file to bin.src

Bug Major Done Done swinbank aritter Fri, 15 Jul 2016 03:23:20 +0000 Tue, 19 Jul 2016 13:09:01 +0000 Tue, 19 Jul 2016 13:09:01 +0000 0 2 <p>Added SConscript file bin.src in drp_stella (tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-42" title="Add SConscript file to bin.src" class="issue-link" data-issue-key="INFRA-42"><del>INFRA-42</del></a>) and obs_pfs (tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-42" title="Add SConscript file to bin.src" class="issue-link" data-issue-key="INFRA-42"><del>INFRA-42</del></a>). While the bin executables ARE getting created now for drp_stella, somehow they are still NOT being created for obs_pfs... <span class="error">&#91;scratches head&#93;</span></p> <p>Work on <tt>obs_pfs</tt> is now ready for review: <a href="https://github.com/Subaru-PFS/obs_pfs/pull/1" class="external-link" rel="nofollow">pull request here</a>.</p> <p>I am confused by what's happened on <tt>drp_stella</tt>: the <tt>tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-42" title="Add SConscript file to bin.src" class="issue-link" data-issue-key="INFRA-42"><del>INFRA-42</del></a></tt> branch contains <a href="https://github.com/Subaru-PFS/drp_stella/commit/8dbd37cfae384dce4d55cfbc5379e135b5cdbfad" class="external-link" rel="nofollow">this commit</a> which looks like it should really be part of <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-33" title="Sort out Spectrum containers" class="issue-link" data-issue-key="PIPE2D-33"><del>PIPE2D-33</del></a>. <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=aritter" class="user-hover" rel="aritter">aritter</a>, I would like to rebase <tt>tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-42" title="Add SConscript file to bin.src" class="issue-link" data-issue-key="INFRA-42"><del>INFRA-42</del></a></tt> to remove that commit before this is merged. Can you confirm that that's ok? I don't want to lose any of your work.</p> <p>Please go ahead John, sorry for that. Guess I had the wrong branch while working on it. Will double-check from now on...</p> <p>Thanks!</p> <p>Now ready for review on both:</p> <ul> <li><a href="https://github.com/Subaru-PFS/drp_stella/pull/2" class="external-link" rel="nofollow">drp_stella branch <tt>tickets/INFRA-42</tt></a></li> <li><a href="https://github.com/Subaru-PFS/obs_pfs/pull/1" class="external-link" rel="nofollow">obs_pfs branch <tt>tickets/INFRA-42</tt></a></li> </ul> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=aritter" class="user-hover" rel="aritter">aritter</a>, you did all the work on drp_stella, so I am happy to sign off on that. Can you please check that you are happy with the changes to obs_pfs?</p> <p>Works for me. What was the problem?</p> <p>The master <tt>SConstruct</tt> file can be set to only build certain "targets" (effectively, directories). If we don't specify, it uses a default list (which includes <tt>bin.src</tt>). However, in obs_pfs that default list was being over-ridden to something which did <b>not</b> include <tt>bin.src</tt>, so the <tt>SConscript</tt> you added wasn't being included.</p> <p>I edited the <tt>SConstruct</tt> to use the defaults (plus an appended <tt>pfs</tt>).</p> <p>Merged.</p> Development Rank 0|02qpuc:zy Reviewers aritter Sprint 2014-15