https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INFRA-227 Software Development Infrastructure <p>Presently I cannot see (but <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=yuki.moritani" class="user-hover" rel="yuki.moritani">yuki.moritani</a> correct me if I am wrong) specific documentation explaining the workflow for a JIRA ticket, and in particular in relation to GitHub Pull Requests and related reviews.</p> <p>The closest documentation I see is <a href="https://pfs-2d-pipeline.readthedocs.io/en/latest/dev/best_practice.html" class="external-link" rel="nofollow">https://pfs-2d-pipeline.readthedocs.io/en/latest/dev/best_practice.html</a> and</p> <p><a href="https://github.com/Subaru-PFS/doc/blob/master/development-management/ticketing-jira.rst" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/doc/blob/master/development-management/ticketing-jira.rst</a></p> <p>but both do not adequately document the workflow. This is important so that updates can be made to software in a controlled manner.</p> INFRA-227

JIRA workflow for PFS needs to be documented

Story Normal Done Done yuki.moritani hassan Wed, 17 Oct 2018 20:10:47 +0000 Sat, 13 Jul 2019 20:27:42 +0000 Sat, 13 Jul 2019 20:27:42 +0000 support 0 2 <p>Initially assigned to <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=yuki.moritani" class="user-hover" rel="yuki.moritani">yuki.moritani</a> but I am happy to work with her on this matter.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a> could you explain what is the difference from <a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-226" title="Add guidelines about Github to the general document" class="issue-link" data-issue-key="INFRA-226">INFRA-226</a> ?</p> <p>My understanding is that <a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-226" title="Add guidelines about Github to the general document" class="issue-link" data-issue-key="INFRA-226">INFRA-226</a> is related to the guideline for branch naming, while this one is more general, covering issue transitions and policy regarding reviews and pull requests.</p> <p>I'm happy to include the above to <a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-226" title="Add guidelines about Github to the general document" class="issue-link" data-issue-key="INFRA-226">INFRA-226</a> and resolve this if you prefer.</p> <p>Thank you for explanation. <br/> I understand your point now.</p> <p>I'd like to ask a question: in general you should work on one branch per one ticket?<br/> I mean, In this case, should I work on these two ticket on individual branch? </p> <p>This is a good point. It should be one branch per single ticket.</p> <p>But I also see for documentation it doesn't make sense to do multiple branches. I think you should simply make all the updates related to both tickets in a single branch, eg <tt>tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-226" title="Add guidelines about Github to the general document" class="issue-link" data-issue-key="INFRA-226">INFRA-226</a></tt>, and resolve this ticket referencing that branch.</p> <p>If you need help with the documentation, please tell me.</p> <p>I see, then separate ticket is fine to me. Thank you for your suggestion.</p> Duplicate PIPE2D-241 Relates INFRA-226 Development Rank 0|s001cw: