<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:53:19 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[FIBERALLOC-46] Update target selection mechanism based on blackspot distance</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/FIBERALLOC-46</link>
                <project id="10500" key="FIBERALLOC">Target to fiber allocation and configuration</project>
                    <description>&lt;p&gt;As discussed during the ICS/PFI telecon 2023-01-20 (&lt;a href=&quot;https://sumire.pbworks.com/w/page/151793943/ICS-PFI-MCS%20telecon%20on%20Jan%2020%202023&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://sumire.pbworks.com/w/page/151793943/ICS-PFI-MCS%20telecon%20on%20Jan%2020%202023&lt;/a&gt;) as part of the target selection scheme, we need to penalize objects that are vignetted by black spots. &lt;/p&gt;

&lt;p&gt;This is part of a long-term solution to recover approx 2% of the patrol region, that is obscured by the blackdot penumbra.&lt;/p&gt;

&lt;p&gt;To do this, a penalty function that depends on the distance the target is from the blackspot will need to be provided elsewhere. I propose this goes through Project Office. This penalty function will be based on target priority observers assign, given the signal-to-noise at that target position.&lt;/p&gt;</description>
                <environment></environment>
        <key id="23223">FIBERALLOC-46</key>
            <summary>Update target selection mechanism based on blackspot distance</summary>
                <type id="3" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10518&amp;avatarType=issuetype">Task</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="Martin.Reinecke">Martin Reinecke</assignee>
                                    <reporter username="hassan">hassan</reporter>
                        <labels>
                            <label>EngRun</label>
                    </labels>
                <created>Thu, 26 Jan 2023 16:42:55 +0000</created>
                <updated>Fri, 17 Mar 2023 14:06:42 +0000</updated>
                            <resolved>Fri, 17 Mar 2023 14:06:41 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>6</watches>
                                                                <comments>
                            <comment id="32131" author="rhl" created="Thu, 26 Jan 2023 18:03:55 +0000"  >&lt;p&gt;At present we are targeting object which are partially vignetted and which thus lose S/N, so this work would allow us to make informed choices about when to target these objects (c. 5% of the PFI field).  We might be able to work further into the spots (gaining back some of the 2%) if we trust blind cobra motions enough, but that&apos;s a higher-order objective.&lt;/p&gt;</comment>
                            <comment id="32133" author="martin.reinecke" created="Thu, 26 Jan 2023 19:28:44 +0000"  >&lt;p&gt;My idea is to add an additional parameter to &lt;tt&gt;buildProblem&lt;/tt&gt; (&lt;a href=&quot;https://github.com/Subaru-PFS/ets_fiberalloc/blob/6f8f272370d03f56bca8fda7b1a11b54fde20cc8/ets_fiber_assigner/netflow.py#L220&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://github.com/Subaru-PFS/ets_fiberalloc/blob/6f8f272370d03f56bca8fda7b1a11b54fde20cc8/ets_fiber_assigner/netflow.py#L220&lt;/a&gt;), which is a function that converts a distance to the nearest black spot center into a penalty. This would be analogous to the already existing &lt;tt&gt;cobraMoveCost|&lt;/tt&gt; parameter. Observers can choose to pass &lt;tt&gt;None&lt;/tt&gt;, in which case no penalty is applied, or a function that implements the desired penalty. I will then simply add the penalties for all visited targets to the overall &quot;cost&quot; of the observation.&lt;/p&gt;

&lt;p&gt;This approach has the advantage of being extremely flexible, but of course also the drawback that all responsibility for the correct tuning of the function lies with the observers. On the other hand, I don&apos;t know who else would have all the required knowledge...&lt;/p&gt;

&lt;p&gt;Does this sound OK?&lt;/p&gt;</comment>
                            <comment id="32142" author="martin.reinecke" created="Fri, 27 Jan 2023 07:53:17 +0000"  >&lt;p&gt;Tentative implementation at &lt;a href=&quot;https://github.com/Subaru-PFS/ets_fiberalloc/pull/16&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://github.com/Subaru-PFS/ets_fiberalloc/pull/16&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Open question: so far we ignore the possibility that a fiber may be in close vicinity to a black dot of a &lt;em&gt;neighbouring&lt;/em&gt; Cobra; we only check against its own black dot. Is that sufficient?&lt;/p&gt;</comment>
                            <comment id="32143" author="mxhf" created="Fri, 27 Jan 2023 08:29:37 +0000"  >&lt;p&gt;good catch Martin. Yes, the previously suggested parameter should certainly penalize observations close to any black dot.&lt;/p&gt;</comment>
                            <comment id="32144" author="martin.reinecke" created="Fri, 27 Jan 2023 08:40:48 +0000"  >&lt;p&gt;I&apos;m not sure if a fiber even can approach a neighbor&apos;s black dot so closely that we need to think about penalizing it.&lt;/p&gt;

&lt;p&gt;Adding the feature is a bit tricky, and it may also increase run-time noticeably, so I&apos;d be happy to get explicit confirmation that this is needed.&lt;/p&gt;</comment>
                            <comment id="32145" author="martin.reinecke" created="Fri, 27 Jan 2023 09:55:39 +0000"  >&lt;p&gt;Looking at the fiber-allocation slack channel, it seems to me that the range where we should penalize assignments is between the actual black dot radius (somewhere around 0.75mm) and roughly 1.15mm. As far as I can see, neighoring fibers cannot come that close to a Cobra&apos;s own black dot, so this should not be necessary. Please correct me if I&apos;m wrong.&lt;/p&gt;</comment>
                            <comment id="32146" author="mxhf" created="Fri, 27 Jan 2023 10:06:23 +0000"  >&lt;p&gt;Fair. It&apos;s probably worthwhile to make that calculation quickly. the focal plane object should expose all required information.&lt;/p&gt;</comment>
                            <comment id="32149" author="yuki.moritani" created="Sun, 29 Jan 2023 01:43:51 +0000"  >&lt;p&gt;In regard to the possibility for given Cobra come close to the area of neighbouring dots, I quickly checked the numbers:&lt;/p&gt;

&lt;p&gt;Measurement in September 2021 showed that distance between cobra and dot is 2.21+/- 0.25 mm ( dx(PFI) = - 0.27 +/- 0.26 mm, dy(PFI) = 2.17 +/- 0.30 mm) on average. (cf. designed value is 2.4mm in PFI-Y axis). If fibers are assigned in full patrol area, there may be a case a given Cobra reach to the neighbouring (in Y direction) dot area, I guess.&lt;/p&gt;</comment>
                            <comment id="32151" author="martin.reinecke" created="Mon, 30 Jan 2023 09:18:36 +0000"  >&lt;p&gt;Thank you! I think I have an idea how to implement this somewhat efficiently, and hope to update the pull request in the next days.&lt;/p&gt;</comment>
                            <comment id="32152" author="martin.reinecke" created="Mon, 30 Jan 2023 11:23:41 +0000"  >&lt;p&gt;This should be fixed now.&lt;/p&gt;</comment>
                            <comment id="32417" author="kiyoto.yabe" created="Fri, 17 Mar 2023 01:21:58 +0000"  >&lt;p&gt;I made a stupid mistake in the implementation in the pfsDesign generation script, which was why it didn&apos;t work well before as reported.&#160;&lt;/p&gt;

&lt;p&gt;Now it looks that it works as we expected. The number of fibers assigned as a function of distance from dot center for various penalty cases is shown in the figure below. Currently, I&apos;m using a form as a function of distance, but it can be changed according to the experience of future observations and experiment.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;a id=&quot;15578_thumb&quot; href=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15578/15578_FIBERALLOC-46_test2.png&quot; title=&quot;FIBERALLOC-46_test2.png&quot; file-preview-type=&quot;image&quot; file-preview-id=&quot;15578&quot; file-preview-title=&quot;FIBERALLOC-46_test2.png&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/thumbnail/15577/_thumb_15577.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/a&gt;&lt;/span&gt;&lt;/p&gt;</comment>
                            <comment id="32419" author="kiyoto.yabe" created="Fri, 17 Mar 2023 14:00:18 +0000"  >&lt;p&gt;Here is another test with multiple priorities depending on brightness. I guess we can control the balance between dot effects and scientific priority by choosing the penalty function. I think the functionality has been implemented and tested, so we can close the ticket and file another one regarding on e.g. more scientific decision.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;a id=&quot;15578_thumb&quot; href=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15578/15578_FIBERALLOC-46_test2.png&quot; title=&quot;FIBERALLOC-46_test2.png&quot; file-preview-type=&quot;image&quot; file-preview-id=&quot;15578&quot; file-preview-title=&quot;FIBERALLOC-46_test2.png&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/thumbnail/15578/_thumb_15578.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/a&gt;&lt;/span&gt;&lt;/p&gt;</comment>
                            <comment id="32420" author="martin.reinecke" created="Fri, 17 Mar 2023 14:06:42 +0000"  >&lt;p&gt;Thank you very much for testing, &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe&quot; class=&quot;user-hover&quot; rel=&quot;kiyoto.yabe&quot;&gt;Kiyoto Yabe&lt;/a&gt;! Closing now.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="15577" name="FIBERALLOC-46_test1.png" size="112135" author="kiyoto.yabe" created="Fri, 17 Mar 2023 01:13:24 +0000"/>
                            <attachment id="15578" name="FIBERALLOC-46_test2.png" size="109031" author="kiyoto.yabe" created="Fri, 17 Mar 2023 13:56:06 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qpjd:00r3000k9</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>