[FIBERALLOC-45] pfilamps fits key should always be set to False if requested time is 0 second

Thu, 29 Sep 2022 00:12:10 +0000

During last engineering run, some arcs has been taken using gen2:
iic scienceArc hgcd=0.0 argon=0.0 neon=10 krypton=0.0 duplicate=1 cam=b1,r1

Some requested lamp time has been set to 0, I suppose because of how gen2 commands are written, that's fine with me, but we have to be careful about book-keeping.

conda-ics) alefur@shell-ics:~$ fitsheader /data/raw/2022-09-24/sps/PFSA07999012.fits |grep 'W_AIT'
W_AITNEO=                    T / Neon lamp was on                               
W_AITARG=                    T / Argon lamp was on                              
W_AITKRY=                    T / Krypton lamp was on                            
W_AITXEN=                    F / Xenon lamp was on                              
W_AITHGC=                    T / HgCd lamp was on                               
W_AITQTH=                    F / Halogen lamp was on                            
(conda-ics) alefur@shell-ics:~$ fitsheader /data/raw/2022-09-24/sps/PFSA07999012.fits |grep 'W_CL'
W_CLNEOT=                   10 / Neon lamp request time                         
W_CLARGT=                    0 / Argon lamp request time                        
W_CLKRYT=                    0 / Krypton lamp request time                      
W_CLXENT=                    0 / Xenon lamp request time                        
W_CLHGCT=                    0 / HgCd lamp request time                         
W_CLQTHT=                    0 / Halogen lamp request time

As you can see, for that visit, the flag has been set to True with time=0.
I'm not sure how drp interpret that, but still I think that flag should be set to False

PFS-JIRA

[FIBERALLOC-45] pfilamps fits key should always be set to False if requested time is 0 second