https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-8 Data Model <p>We need 64 bit object IDs to encode all the information in an HSC objectID: (tract, patch, filter, objId) or (visit, ccd, objId). The data model talks about 64bit IDs, but only specifies enough hexadecimal digits (8) in filenames to write out 32bits.</p> <p>Please change the objId filename formats to "%016d"</p> <p>(and thanks to Shimono-san who pointed out a related problem in <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-4" title="Hash need to be 8byte" class="issue-link" data-issue-key="DAMD-4"><del>DAMD-4</del></a>)</p> DAMD-8

Object IDs need to be 64bits, so 16 hex digits

Story Major Done Done hassan rhl Sat, 3 Sep 2016 23:37:34 +0000 Thu, 23 May 2019 18:31:38 +0000 Thu, 23 May 2019 18:31:38 +0000 0 2 <p>Instead of implementing a <tt>%16d</tt> format according to original description, will implement <tt>%16x</tt>.</p> <p>Example output filenames from a recent integration test run using the fixed version of </p> {obs_pfs} <p> are shown below:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> rerun<span class="code-comment">//integration/pipeline/pfsCoadd/000/00000/0,0/pfsCoadd-000-00000-0,0-0000000000000001-004-1eab2e92.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsCoadd/001/00000/0,0/pfsCoadd-001-00000-0,0-000000000000004c-004-1eab2e92.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsCoadd/001/00000/0,0/pfsCoadd-001-00000-0,0-000000000000005e-002-f1e1e95a.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsCoadd/001/00000/0,0/pfsCoadd-001-00000-0,0-0000000000000037-004-1eab2e92.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsCoadd/001/00000/0,0/pfsCoadd-001-00000-0,0-0000000000000070-004-1eab2e92.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsCoadd/001/00000/0,0/pfsCoadd-001-00000-0,0-0000000000000012-004-1eab2e92.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsCoadd/001/00000/0,0/pfsCoadd-001-00000-0,0-0000000000000069-002-2036187a.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsCoadd/001/00000/0,0/pfsCoadd-001-00000-0,0-0000000000000047-004-1eab2e92.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsCoadd/001/00000/0,0/pfsCoadd-001-00000-0,0-0000000000000073-004-1eab2e92.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/000/00000/0,0/pfsObject-000-00000-0,0-0000000000000001-000032.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/000/00000/0,0/pfsObject-000-00000-0,0-0000000000000001-000033.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/000/00000/0,0/pfsObject-000-00000-0,0-0000000000000000-000033.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/000/00000/0,0/pfsObject-000-00000-0,0-0000000000000000-000032.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000070-000032.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000037-000033.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000047-000033.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000069-000033.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-000000000000004c-000032.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-000000000000004c-000033.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000047-000032.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000070-000033.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000037-000032.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000073-000033.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000073-000032.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-000000000000005e-000032.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000012-000033.fits </span>rerun<span class="code-comment">//integration/pipeline/pfsObject/001/00000/0,0/pfsObject-001-00000-0,0-0000000000000012-000032.fits</span> </pre> </div></div> <p>It looks as if you forgot to change the format for the pfsVisitHash at the same time.  It needs to be <tt>0x016x</tt> (I don't know what happened to the <tt>0x</tt> that's mandated in the datamodel):</p> <p><tt>"pfsObject-%05d-%s-%3d-%016x-%02d-0x%016x.fits" % (tract, patch, catId, objId, nVisit % 100, pfsVisitHash)</tt></p> <p>Please check all the patterns. Incidentally, I think that the <tt>datamodel</tt> package has examples of all the files that are generated when you make it, so you should have been able to check the filenames that way. It would be worth checking that it's still true that the examples are complete and correct.</p> <p>Also, while I know that you're quoting outputs from the code, <tt>pfsCoadd</tt> is not in the datamodel.</p> <p>The change in format of <tt>pfsVisitHash</tt> is not the topic of this particular ticket, so if that is needed I'll raise a separate one to address that. </p> <p>My comment in <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-4" title="Hash need to be 8byte" class="issue-link" data-issue-key="DAMD-4"><del>DAMD-4</del></a> claims that the hash problem is fixed (but I think I may be lying).  Could you check before raising a new ticket? We should make sure that all these formatting tickets are merged at the same time.</p> <p>Merged to master (commit 60d300c).</p> Blocks DAMD-57 Relates DAMD-56 DAMD-58 Development Rank 0|ii00nb: