https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-69 Data Model <p>The names <tt>pfsSpectra.py</tt> and <tt>pfsSpectrum.py</tt> are confusing. For example, a <tt>pfsSpectra</tt> object does not strictly contain multiple <tt>pfsSpectrum</tt> s. Consider alternative names.</p> DAMD-69

Rename pfsSpectra and pfsSpectrum

Story Normal Done Done price hassan Fri, 20 Dec 2019 00:53:26 +0000 Mon, 4 Jan 2021 20:23:04 +0000 Wed, 25 Mar 2020 00:00:21 +0000 0 2 <p>I don't think I'm the person to ask to consider new names, as I've already given them the best names I could think of. I'm happy to implement this once new names are decided, but that needs input (and probably a directive) from people who aren't me.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> says: "<tt>PfsFiberArray</tt> and <tt>PfsFiberArraySet</tt>. I really don't want to use a word related to spectrum when (as you point out) we have a <tt>Spectrum</tt> and <tt>SpectrumSet</tt> already".</p> <p>We also need to muck with the docstrings in the inheritance to replace any instances of the base class name.</p> <p>Changes only to the implementation: rename the classes, and fix up the docstrings.</p> <p>Merged to master.</p> Relates PIPE2D-492 Development Rank 0|02qprn:4 Reviewers hassan Sprint 2DDRP-2021 A Story Points 1.0