https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-67 Data Model <p>The <tt>PfsObject.OBSERVATIONS</tt> table needs to track the visits used to construct that <tt>PfsObject</tt>. Please update the code accordingly.</p> DAMD-67

Update PfsObject to track input visits in the OBSERVATIONS table

Story Normal Done Done price hassan Tue, 17 Dec 2019 14:27:47 +0000 Mon, 4 Jan 2021 20:23:03 +0000 Wed, 25 Mar 2020 03:40:41 +0000 0 5 <p>The current code does track the visits, but it also includes other information (more accurately, it includes a string representation of the expanded <tt>dataId</tt>, looking like a python <tt>dict</tt>). The original datamodel was a binary table (<tt>CONFIG</tt>) with just the visits and pfsDesignId, but I think adding columns for 3 arms makes sense (I can certainly imagine times that we'll omit particular arms from the pfsObject), and adding the fiberId makes the lookup of e.g. the fibre position in the pfsConfig file easier.<br/> <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a>: do we need anything else in the dataId? I see things like:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> {<span class="code-quote">'field'</span>: <span class="code-quote">'OBJECT'</span>, <span class="code-quote">'dateObs'</span>: <span class="code-quote">'2019-10-23'</span>, <span class="code-quote">'site'</span>: <span class="code-quote">'F'</span>, <span class="code-quote">'category'</span>: <span class="code-quote">'A'</span>, <span class="code-quote">'visit'</span>: 36, <span class="code-quote">'arm'</span>: <span class="code-quote">'b'</span>, <span class="code-quote">'spectrograph'</span>: 1, <span class="code-quote">'ccd'</span>: 0, <span class="code-quote">'filter'</span>: <span class="code-quote">'b'</span>, <span class="code-quote">'expTime'</span>: 900.0, <span class="code-quote">'dataType'</span>: <span class="code-quote">'OBJECT'</span>, <span class="code-quote">'taiObs'</span>: <span class="code-quote">'2019-10-23'</span>, <span class="code-quote">'pfsDesignId'</span>: 1, <span class="code-quote">'slitOffset'</span>: 0.0} </pre> </div></div> <p>visit, spectrograph and arm are sufficient to specify an image, but in combination with the objId (known if we're talking about a <tt>pfsObject</tt>) the spectrograph isn't required (since it can be obtained from the <tt>pfsConfig</tt>). So I think visit and arm are sufficient.</p> <p>I propose to have <tt>visit</tt> and <tt>arm</tt> columns, but keep the <tt>identity</tt> column as a useful convenience.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a>, would you mind signing off on this?</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> would like for us to include fiberId, spectrograph, pfsDesignId in addition to visit and arm.</p> <p>I took this opportunity to make things a lot more structured: removing the <tt>identity</tt> dict, and replacing it with a struct called <tt>Identity</tt>. I hope this will make things easier for users, who now no longer need to know the magic keywords <tt>visit</tt>, <tt>arm</tt>, <tt>spectrograph</tt> when they make a <tt>dataId</tt>; rather, the struct they need has the keywords in the API and the docs.</p> <p>I believe <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> agreed with the ideas. Will reassign the review to <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a> so he can approve the implementation.</p> <p>Merged to master.</p> Blocks DAMD-68 Relates PIPE2D-492 Development Rank 0|02qprn: Reviewers hassan Sprint 2DDRP-2021 A Story Points 1.0