https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-65 Data Model <p>The implementation of the 2D pipeline (most notably in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-310" title="Modify pipeline flow to match design" class="issue-link" data-issue-key="PIPE2D-310"><del>PIPE2D-310</del></a>) involved several changes to the datamodel that were not approved through the usual change control procedure, but were nevertheless merged. This ticket seeks retrospective approval for those changes.</p> <p>I will survey the 2D pipeline products as currently implemented, use this to update <tt>datamodel.txt</tt>, and provide a summary here of the changes which can be debated.</p> DAMD-65

Retrospective approval of 2D pipeline-related changes

Story Normal Done Done price price Wed, 28 Aug 2019 16:36:17 +0000 Thu, 26 Sep 2019 00:35:37 +0000 Wed, 25 Sep 2019 21:56:55 +0000 0 1 <p>Here are the changes I'm proposing to the datamodel:</p> <ul> <li>Added calibDate to bias, dark, flat, fiberTrace filenames (I think this is potentially useful, but easy to remove if there's disagreement).</li> <li>Updated the header keywords used to track the inputs for calibs: "VISIT%03d" --&gt; "CALIB_INPUT_%d" (set by LSST code)</li> <li>Added "targetType" in pfsDesign/pfsConfig (was missing)</li> <li>Specify degrees for pfsDesign/pfsConfig boresight coordinates (missing)</li> <li>Changed name of HDU "CONFIG" --&gt; "IDENTITY" in pfsArm and fixed order of HDUs (to match implementation)</li> <li>Added catId to directory structure for pfsObject (overlooked in previous revisions)</li> </ul> <p>Here's <a href="https://github.com/Subaru-PFS/datamodel/pull/28/files#diff-97accc771ca97a2a2923438410b01055" class="external-link" rel="nofollow">the diff of changes to datamodel.txt</a>.</p> <p>I've also made several code changes to bring the implementation into compliance with the datamodel (see GitHub pull requests).</p> <p>Note: pfsObject is not compliant after these changes; that's <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-63" title="Redesign and implement pfsObject FluxTbl" class="issue-link" data-issue-key="DAMD-63"><del>DAMD-63</del></a>.</p> <p>Merged to master.</p> Relates DAMD-63 PIPE2D-310 Development Rank 0|02qpt6:508yl03zc004 Reviewers hassan Sprint 2DDRP-2019 G Story Points 5.0