https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-62 Data Model <p>I noticed that the filename format for pfsObject (and pfsSingle and pfsReference as well) described in drp.py is</p> <p>"pfsObject-%(catId)03d-%(tract)05d-%(patch)s-%(objId)016x-%(nVisit)03d-%(pfsVisitHash)016x.fits"</p> <p>, but, according to datamodel.txt, it should be</p> <p>"pfsObject-%05d-%s-%03d-%016x-%03d-0x%016x.fits" % (tract, patch, catId, objId, nVisit % 1000, pfsVisitHash)</p> <p>(I mean the location of catId is different)</p> <p>Could tell me which one is correct?</p> DAMD-62

Change filenameFormat for pfsObject or update datamodel.txt

Task Normal Done Done hassan Kiyoto Yabe Tue, 25 Jun 2019 08:09:32 +0000 Thu, 29 Aug 2019 18:23:06 +0000 Tue, 27 Aug 2019 16:48:38 +0000 0 4 <p>The definition in datamodel.txt is correct. I will update the formats in <tt>drp.py</tt> accordingly.</p> <p>Initial fix pushed to branch. Unit test being considered.</p> <p>I think that the fix should be to change <tt>datamodel.txt</tt>, not the code. The reason for this is sorting: <tt>catId</tt> is the most fundamental discriminator between spectra (e.g., it's the difference between a galactic archeology target and a high-z quasar target) and should therefore be listed first in the filename so that a sorted list of files will group the common <tt>catId</tt> files together.</p> <p>The version in the datamodel.txt is correct by definition, so the drp.py should have conformed. If we wanted to move the catId to the front, that should have been filed as a DAMD ticket <b>before</b> the change was made.</p> <p>I agree that the change is reasonable (especially as while most PFS SSP targets will come from HSC, and thus have <tt>catId==1</tt> the GA ones will not). In the interest of efficiency let us take this ticket as the one that proposes the change. Normally this would come up for discussion at the DRP meeting where we discuss both 1-D and 2-D, but if <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a> chooses I think we can make this decision in a less formal way as the codebase is already broken and LAM is about to be off for the month of Août.</p> <p>Proposal from <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a> agreed: <tt>catId</tt> will now be the first element of the file name.</p> <p><tt>datamodel.txt</tt> and the code base need to be updated accordingly as part of this ticket.</p> <p>Fixed in 15d0cf0.</p> Development Rank 0|02qpt6:508yl03zc9 Reviewers price Sprint 2DDRP-2019 F 2DDRP-2019 G Story Points 2.0