https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-60 Data Model <p>Following the refactoring in Jan 2019 (<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-310" title="Modify pipeline flow to match design" class="issue-link" data-issue-key="PIPE2D-310"><del>PIPE2D-310</del></a>) where a lot of the datamodel classes have been moved to <tt>drp.py</tt>, some utility code have not yet been updated accordingly so are currently not usable.</p> <p>These include:</p> <ul> <li>makePsfObject.py</li> <li>driver.py</li> <li>datamodel.ipynb</li> </ul> <p>Please update them.</p> DAMD-60

driver.py, makePfsObject.py and datamodel.ipynb need updating

Story Normal Done Done price hassan Tue, 11 Jun 2019 13:10:31 +0000 Thu, 11 Jul 2019 14:11:57 +0000 Thu, 11 Jul 2019 00:28:00 +0000 0 3 <ul> <li><tt>makePfsObject.py</tt> is deliberately broken. I extracted it from another file when I built the end-to-end pipeline. I didn't delete it because one of its features (populating the <tt>fluxtbl</tt>) hasn't been incorporated into the pipeline. I think the process of resampling and coadding should belong in the algorithmic code of drp_stella rather than datamodel. I propose creating a ticket to implement the <tt>fluxtbl</tt> functionality in the pipeline.</li> <li><tt>bin/driver.py</tt> is awfully named. It appears to plot spectra from a <tt>PfsArm</tt>, then combine them into a <tt>PfsObject</tt> and plot them. I propose replacing this with a couple of <tt>bin</tt> scripts that will plot a <tt>PfsArm</tt> and <tt>PfsObject</tt>. As previously, I believe the algorithmic code doing the resampling and coadding should belong in drp_stella.</li> <li><tt>notebooks/datamodel.ipynb</tt> appears to have been a developmental aid. It duplicates much of the old code. I propose to delete it.</li> </ul> <p>Regarding <tt>makePfsObject</tt>: Yabe-san requires a tool to create a <tt>PfsObject</tt> from a <tt>PfsArm</tt> instance. See His comment in <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-59" title="How can I make pfsArm object?" class="issue-link" data-issue-key="DAMD-59"><del>DAMD-59</del></a>: <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-59?focusedCommentId=15646&amp;page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15646" class="external-link" rel="nofollow">https://pfspipe.ipmu.jp/jira/browse/DAMD-59?focusedCommentId=15646&amp;page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15646</a> . If your suggestion enables him to do that operation, that's fine (it's also fine to have such a tool in drp_stella). </p> <p><a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-438" title="Implement fluxtbl" class="issue-link" data-issue-key="PIPE2D-438"><del>PIPE2D-438</del></a> is the ticket for implementing the <tt>fluxtbl</tt>. This will likely involve changes to the datamodel; I'll make a DAMD ticket once I know what those are.</p> <p>I tested out the plotting scripts, and they appear to work fine.</p> <p>I'm a bit confused, but there appears to be "FLUXTBL" HDU in the current pfsObject, which contains the merged spectrum. So, are you going to rename FLUXTBL to FLUX and add FLUXTBL for the original spectra, right?</p> <p>Related to the question above, I made pfsObject following codes in drp_stellar, but the HDU list of the generated fits file is :</p> <p>HDU0 Primary</p> <p>HDU1 FLUXTBL</p> <p>HDU2 TARGET</p> <p>HDU3 SKY</p> <p>HDU4 OBSERVATIONS</p> <p>HDU5 COVAR</p> <p>HDU6 COVAR2</p> <p>, which is different from the description in the datamodel.txt:</p> <p>HDU #0 PDU</p> <p>HDU #1 FLUX   </p> <p>HDU #2 FLUXTBL</p> <p>HDU #3 COVAR   </p> <p>HDU #4 COVAR2   </p> <p>HDU #5 MASK       </p> <p>HDU #6 SKY         </p> <p>HDU #7 CONFIG  </p> <p>So, which one do we take?</p> <p> </p> <p> </p> <p> </p> <p>I screwed up the implementation of the pfsObject FITS HDUs when I implemented the end-to-end pipeline, since I didn't understand what <tt>FLUXTBL</tt> was meant for. So yes, I think I need to rename what is now <tt>FLUXTBL</tt> to <tt>FLUX</tt>, redesign <tt>FLUXTBL</tt> (the original design did not support multiple visits) and provide an implementation for populating it, and update <tt>datamodel.txt</tt>. Filed <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-63" title="Redesign and implement pfsObject FluxTbl" class="issue-link" data-issue-key="DAMD-63"><del>DAMD-63</del></a> for that.</p> <p>Changes acceptable.</p> <p>Merged to master.</p> Relates DAMD-59 PIPE2D-310 Development Rank 0|02qpt6:508yjm9 Reviewers hassan Sprint 2DDRP-2019 F Story Points 2.0