https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-59 Data Model <p>I'm checking the latest datamodel (60d300c77b67207001aeeb84468436722b224009) now, but I'm not sure how to make pfsArm file. Is pfsArm.py dismissed?</p> DAMD-59

How can I make pfsArm object?

Story Normal Won't Fix Won't Fix price Kiyoto Yabe Tue, 11 Jun 2019 08:05:25 +0000 Wed, 21 Aug 2019 17:58:26 +0000 Wed, 21 Aug 2019 17:58:26 +0000 0 3 <p>Following some refactoring earlier this year, the PfsArm class has been refactored and moved to drp.py.</p> <p>Here's skeleton code for creating a PfsArm file:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> from pfs.datamodel.drp <span class="code-keyword">import</span> PfsArm [...] PfsArm(dataId, fiberIds, wavelength, flux, mask, sky, covar, flags, metadata) </pre> </div></div> <p>For the constructor parameters, see also the docString for parent class <tt>PfsSpectra</tt> in pfsSpectra.py .</p> <p>Assigned to <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a> to provide additional support.</p> <p>OK. I'll give it a try.</p> <p>Then, another question arises. How can I make a pfsObject from a set of pfsArm objects? Previously, we used makePfsObject.py but it seems to be outdated. Is it possible to update makePfsObject.py? Or, is there an easy way to do that?</p> <p>Can you use the <tt>MergeArmsTask</tt> in drp_stella? If not, what are you trying to do?</p> <p>The <a href="https://github.com/Subaru-PFS/drp_doc/tree/master/design" class="external-link" rel="nofollow">DRP design document</a> is slightly outdated now, but it might be useful to read.</p> <p>We can use it if it is included in datamodel package. We (ETC users) don't want to install the DRP packages. What I want to do is just to make both pfsArm and pfsObject fits files with simulated spectra included. I could make pfsArm file using drp.py but not for pfsObject...</p> <p>Making a <tt>PfsObject</tt> from <tt>PfsArm</tt> files necessarily involves algorithmic code (interpolation and coaddition), which I think would be good to keep out of the data model package. Perhaps you could copy the implementation from <a href="https://github.com/Subaru-PFS/drp_stella/blob/master/python/pfs/drp/stella/mergeArms.py#L151-L200" class="external-link" rel="nofollow">MergeArmsTask</a>?</p> <p>Alternatively, I have been working on updating the 1D simulator (ticket <a href="https://pfspipe.ipmu.jp/jira/browse/SURVEY-7" title="Update the link to the datamodel submodule in ETC" class="issue-link" data-issue-key="SURVEY-7"><del>SURVEY-7</del></a>?), and have just been waiting for the recent changes to settle before pushing it out.</p> <p>I think the remaining questions are addressed in <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-63" title="Redesign and implement pfsObject FluxTbl" class="issue-link" data-issue-key="DAMD-63"><del>DAMD-63</del></a>.</p> Relates DAMD-60 Development Rank 0|02qpso:i Sprint 2DDRP-2019 F