https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-58 Data Model <p>It was discovered while implementing <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-56" title="Change pfsVisitHash formatting from %08x to 0x%016x" class="issue-link" data-issue-key="DAMD-56"><del>DAMD-56</del></a> that 64 bit hash values could not be generated due to a limitation with <tt>PropertySet</tt> (see <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-56?focusedCommentId=15423&amp;page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15423" class="external-link" rel="nofollow">https://pfspipe.ipmu.jp/jira/browse/DAMD-56?focusedCommentId=15423&amp;page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15423</a>). Object IDs, however, need to use the full 64-bit range. </p> <p>It needs to be checked whether object IDs are prone to the same problem as hash values and if so, a correction needs to be made to the code.</p> DAMD-58

Ensure that Object ID range covers the full 64 bits

Story Normal Done Done price hassan Thu, 23 May 2019 15:34:05 +0000 Wed, 25 Sep 2019 19:12:56 +0000 Wed, 25 Sep 2019 18:48:37 +0000 0 3 <p>Attached python script demonstrates that when supplying an Object ID with the highest bit set, an error is raised with <tt>PropertySet</tt>.</p> <p>Need to fix this in the LSST stack, making use of the <tt>&lt;uint64_t&gt;</tt> type. Quoting <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> in an email to <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a> 2019-05-28 below:</p> <blockquote> <p>We'll have to fix the LSST C++, but I don't think it's hard. Probably just a specialisation for &lt;uint64_t&gt;, but possibly a hook in the pybind11 layer too. Paul can do it.</p></blockquote> <p>Re-assigning ticket to <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a> to fix.</p> <p>We need to fix this in LSST, and then we need to worry about how to get the changes into the stack we use.</p> <p>Filed <a href="https://jira.lsstcorp.org/browse/DM-20506" class="external-link" rel="nofollow">DM-20506: Allow PropertySet to handle 64-bit integers</a> on the LSST side. I have a fix based on LSST 16.0 that I'll port.</p> <p>Regarding how to get the changes into the stack we use, we essentially have two choices: upgrade our base stack (e.g., to hscPipe 7.x or LSST 18.x once it comes out with the fix we need), or find some way to inject the fixes into the stack we have now. I'm hoping to go with the latter, since this is a generic problem (wanting fixes in LSST that haven't been released yet).</p> <p>The LSST 18.0 release is imminent, but the LSST SQuARE team have agreed in principle to doing a fast turnaround on a patch release including the relevant work.</p> <p>See also <a href="https://jira.lsstcorp.org/browse/RFC-618" class="external-link" rel="nofollow">https://jira.lsstcorp.org/browse/RFC-618</a> for updates as to the availability of LSST v18.1.0</p> <p>Only trivial changes are required once we upgrade to LSST 18.1.0.</p> <p>P.S. Deleted the <tt>tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-58" title="Ensure that Object ID range covers the full 64 bits" class="issue-link" data-issue-key="DAMD-58"><del>DAMD-58</del></a></tt> branch in drp_stella, which had my original attempts to fix this through monkey-patching. That didn't end up working, and LSST 18.1.0 solves the problem.</p> <p>Merged to master.</p> Blocks PIPE2D-442 Relates DAMD-8 DAMD-56 Development Rank 0|02qpt6:508yl03zc00i Reviewers hassan Sprint 2DDRP-2019 F 2DDRP-2019 G Story Points 2.0