https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-56 Data Model <p>Currently the above hash is truncated to 8 hex digits, zero-padded. Please correct to 16 hex digits, zero-padded.</p> <p>As mentioned by @rhl in a comment in <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-8" title="Object IDs need to be 64bits, so 16 hex digits" class="issue-link" data-issue-key="DAMD-8"><del>DAMD-8</del></a>: also ensure that the hash component is preceded by <tt>0x</tt> to indicate a hash, as specified in <tt>datamodel.txt</tt>. This is not the case currently.</p> DAMD-56

Change pfsVisitHash formatting from %08x to 0x%016x

Story Normal Done Done hassan hassan Mon, 6 May 2019 17:31:24 +0000 Thu, 23 May 2019 18:34:22 +0000 Thu, 23 May 2019 18:34:22 +0000 0 2 <p>With the version of the LSST slack used by the PFS (v16), there is a problem supplying 64 bit hashes to the butler. See attached log file run033.log .</p> <p>The problem can be reduced to the example below.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">import</span> lsst.daf.base as dafBase ps = dafBase.PropertySet() ps.set(<span class="code-quote">'aa'</span>, 0x7fffffffffffffff) ps.set(<span class="code-quote">'bb'</span>, 0xffffffffffffffff) </pre> </div></div> <p>The second <tt>set</tt> call leads to the following error:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> Traceback (most recent call last): File <span class="code-quote">"&lt;stdin&gt;"</span>, line 1, in &lt;module&gt; File <span class="code-quote">"/Users/hassans/LSST/stack/v16/stack/miniconda3-4.3.21-10a4fa6/DarwinX86/daf_base/16.0/python/lsst/daf/base/propertyContainer/propertyContainerContinued.py"</span>, line 193, in set <span class="code-keyword">return</span> _propertyContainerSet(self, name, value, self._typeMenu) File <span class="code-quote">"/Users/hassans/LSST/stack/v16/stack/miniconda3-4.3.21-10a4fa6/DarwinX86/daf_base/16.0/python/lsst/daf/base/propertyContainer/propertyContainerContinued.py"</span>, line 130, in _propertyContainerSet <span class="code-keyword">return</span> getattr(container, <span class="code-quote">"set"</span> + setType)(name, value, *args) TypeError: setLongLong(): incompatible function arguments. The following argument types are supported: 1. (self: lsst.daf.base.propertyContainer.propertySet.PropertySet, name: str, value: <span class="code-object">int</span>) -&gt; None 2. (self: lsst.daf.base.propertyContainer.propertySet.PropertySet, name: str, value: List[<span class="code-object">int</span>]) -&gt; None Invoked with: &lt;lsst.daf.base.propertyContainer.propertySet.PropertySet object at 0x101cce3b0&gt;, <span class="code-quote">'bb'</span>, 18446744073709551615 </pre> </div></div> <p>The conclusion of this is that we will proceed with <b>63 bits</b> instead of 64 bits for the hash.</p> <p>This isn't a butler problem, it's a <tt>lsst.daf.base.PropertySet</tt> problem.</p> <p>The fix should be made in <tt>python/pfs/datamodel/utils.py</tt> and <tt>python/pfs/datamodel/target.py</tt> (or probably we should refactor this to put the truncation in only one place)</p> <p>Merged to master (commit 470907c).</p> Blocks DAMD-57 Relates DAMD-58 DAMD-4 DAMD-8 Development Rank 0|zx00bc: Story Points 1.0