https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-142 Data Model <p>variant and designId0 are not propagated to pfsConfig file</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>In [5]: config = PfsConfig.read(0x240c7969c1532146, 82045) In [6]: design = PfsDesign.read(0x240c7969c1532146) In [7]: design.variant Out[7]: 8 In [8]: config.variant Out[8]: 0 </pre> </div></div> DAMD-142

variant and designId0 are not propagated to pfsConfig file

Bug Normal Done Done arnaud.lefur arnaud.lefur Tue, 15 Nov 2022 14:05:55 +0000 Sat, 19 Nov 2022 06:20:16 +0000 Sat, 19 Nov 2022 06:20:16 +0000 0 2 <p>Changes look fine, but propose adding a simple test to check that the variant information is correctly propagated, eg: </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> def testPfsConfigVariants(self): <span class="code-quote">"""Test that pfsConfig can be create from a design with variant "</span>"" design0 = self.makePfsDesign() variant1 = 1 design1 = self.makePfsDesign(variant=variant1, designId0=design0.pfsDesignId) config1 = PfsConfig.fromPfsDesign(design1, self.visit0, self.pfiCenter) self.assertEqual((variant1, design0.pfsDesignId), config1.getVariant()) </pre> </div></div> <p>Sure, can you push the change on the branch ?</p> <p>Change pushed to ticket branch.</p> <p>merged to master.</p> Development Rank 0|zzsvif: Reviewers hassan Story Points 1.0