https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-137 Data Model <p>As discussed on the #obsproc slack channel on 2022-10-02, we need to support fast-moving objects for PFS.</p> <p>The <tt>GUIDESTARS</tt> table <em>does</em> have proper motion support as we were worried about extra-Galactic sources, but we didn't think about target stars.</p> <p>Please add <tt>epoch, pmRa, pmDec, parallax</tt> to the <tt>DESIGN</tt> table, with definitions identical to those for the guidestars.</p> <p>When designing plates we need to pay attention to these columns, but the exact observing date shouldn't matter (as we finalise the cobra positions just before observing).</p> DAMD-137

Support proper motion and parallax for targets in pfsDesign files

Story Normal Done Done monodera rhl EngRun Tue, 4 Oct 2022 14:16:04 +0000 Tue, 25 Jul 2023 12:12:07 +0000 Tue, 25 Jul 2023 12:12:07 +0000 0 5 <p>I made a pull request as follows.</p> <p><a href="https://github.com/Subaru-PFS/datamodel/pull/117" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/datamodel/pull/117</a></p> <p>I also ran pytest with "python3 -m pytest -v ./tests/test_PfsConfig.py" and appeared to succeed (log file is attached as log.pytest_test_PfsConfig).</p> <p>New parameters (epoch, pmRa, pmDec, and parallax) are put after fiberstatus argument when initializing the classes. If there is a more suitable place, please let me know.</p> <p>Apparently, the integration test fails because of no backward compatibility at this moment. I'm wondering how it shoudl be implemented. Can I just ignore the existence of these new columns (epoch, pmRa, pmDec, and parallax) when reading a pfsDesign? (maybe throw a warning or info?)</p> <p>Here is the link to the line where columns are checked.<br/> <a href="https://github.com/Subaru-PFS/datamodel/blob/350664261593366ba36d28ab5a43900546be4429/python/pfs/datamodel/pfsConfig.py#L502" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/datamodel/blob/350664261593366ba36d28ab5a43900546be4429/python/pfs/datamodel/pfsConfig.py#L502</a></p> <p>The same also applies to <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-146" title="Add a column for proposal ID in DESIGN/CONFIG table in pfsDesign/pfsConfig files" class="issue-link" data-issue-key="DAMD-146"><del>DAMD-146</del></a> (proposalId and obCode).</p> <p>There are examples of backward compatibility in the lines after the one you point to.</p> <p>If any of the columns is not present, set it to a reasonable default (<tt>epoch="J2000.0", pmRa=0, pmDec=0, parallax=0</tt>).</p> <p>Looks good, backward compatibility is working.<br/> When also need to update opdb schema, eg adding proper columns in pfs_design_fiber and modify the ingest script to populate those.</p> <p>I have updated the opDB schema. Please see the ticket branch for the column names.</p> <p>All products has been merged and tagged as w.2023.30a.<br/> Currently running on the summit / hilo</p> Development Rank 0|02qpjd:00r20060i2001864032 Sprint Eng12July Story Points 2.0