https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-136 Data Model <p>As pointed out by <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=monodera" class="user-hover" rel="monodera">monodera</a> in <a href="https://pfspipe.ipmu.jp/jira/browse/OBSPROC-28" title="duplication of objId in pfsDesign.guideStars" class="issue-link" data-issue-key="OBSPROC-28"><del>OBSPROC-28</del></a>, the <tt>PfsDesign.fromFits()</tt> method reads in the <tt>objId</tt> as a 32-bit integer rather than a 64-bit integer, as defined in <tt>datamodel.txt</tt>. </p> <p>This could lead to truncation issues when loading guide star data from <tt>PfsDesign</tt> or <tt>PfsConfig</tt> files. Please fix.</p> DAMD-136

Datamodel reads in pfsDesign.guideStar objIds as 32bit not 64bit

Bug Major Done Done hassan hassan Sat, 17 Sep 2022 01:29:22 +0000 Sat, 24 Sep 2022 16:37:08 +0000 Sat, 17 Sep 2022 17:02:10 +0000 0 4 <p>Trivial fix. Added unit test to verify and also tested with Hilo <tt>/data/pfsDesign/pfsDesign-0x74f2c06289c9823d.fits</tt> as noted in <a href="https://pfspipe.ipmu.jp/jira/browse/OBSPROC-28" title="duplication of objId in pfsDesign.guideStars" class="issue-link" data-issue-key="OBSPROC-28"><del>OBSPROC-28</del></a>, using following script:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> from pfs.datamodel.pfsConfig <span class="code-keyword">import</span> PfsDesign a = PfsDesign.read(0x74f2c06289c9823d, dirName=<span class="code-quote">'.'</span>) objId = a.guideStars.objId <span class="code-keyword">assert</span>(len(set(objId)) == len(objId)) print(<span class="code-quote">'ObjectIds are unique'</span>) </pre> </div></div> <p><a href="https://github.com/Subaru-PFS/datamodel/pull/102" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/datamodel/pull/102</a> reviewed by Paul Price and accepted.</p> <p>merged to master. </p> Relates INSTRM-1716 OBSPROC-28 Development Rank 0|zzsuon: Reviewers price Story Points 1.0