https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-126 Data Model <p>The datamodel.txt mentions the AG Camera ID <tt>agId</tt> for the guidestar information in the <tt>pfsDesign</tt> and <tt>pfsConfig</tt> entities, but not explicitly the start value (0 or 1).</p> <p>Specify what the start value should be.</p> DAMD-126

Specify start value for AG camera ID (agId)

Task Normal Done Done hassan hassan Fri, 17 Dec 2021 12:40:54 +0000 Fri, 17 Dec 2021 20:15:14 +0000 Fri, 17 Dec 2021 20:15:14 +0000 0 1 <p>Following discussions between <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hiro" class="user-hover" rel="hiro">Yoshida, Hiroshige</a>, <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=yuki.moritani" class="user-hover" rel="yuki.moritani">yuki.moritani</a> and <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a>, it has been agreed that the <tt>agId</tt> should start at 0. </p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hiro" class="user-hover" rel="hiro">Yoshida, Hiroshige</a> comments:</p> <blockquote> <p>I don't know a definitive answer. Certainly, it is more convenient<br/> internally to use a zero-based numbering system (e.g., for indexing<br/> arrays), and that is what I do in the current implementation of the AG<br/> subsystem and opDB/FITS data it generates. On the other hand, the AG<br/> cameras are currently numbered 1 through 6, so we may eventually need to<br/> convert between zero-based and one-based numbering systems somewhere,<br/> likely when data products are generated, consumed, and/or presented.</p></blockquote> <p>Comments from Craig:</p> <blockquote> <p>I don’t feel very strongly about it. Given the choice I always prefer 0-based. But it is true and unchangeable that all the PFI ids (cobras, fibers, holes, modules, boards, fields, etc) are 1-based. If we will really talk about the AGs as part of the PFI we should probably make them 1-based. But I think we will not: the AGs are imagers and simply set the field. So I vote for 0-based.</p></blockquote> <p>Trivial documentation update. Merged to master without review.</p> Development Rank 0|zzsh26:zzi Sprint 2DDRP-2021 A12 Story Points 1.0