<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 15:33:20 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[DAMD-12] Change order of spectrograph and arm in data model from e.g. 1r to e.g. r1</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/DAMD-12</link>
                <project id="10400" key="DAMD">Data Model</project>
                    <description>&lt;p&gt;Currently the data model specifies that we include the spectrograph number and arm in filenames as e.g.&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
 &lt;span class=&quot;code-quote&quot;&gt;&quot;pfsArm-%06d-%1d%1s.fits&quot;&lt;/span&gt; % (visit, spectrograph, arm)
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;Unfortunately, some outputs (e.g. calibrated exposures) are written as&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
 &lt;span class=&quot;code-quote&quot;&gt;&quot;%1s%1d&quot;&lt;/span&gt; % (arm, spectrograph)
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;so something has to be changed.  I&apos;d like to change it from e.g. &quot;1r&quot; to e.g. &quot;r1&quot; as:&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;consistency is vital!&lt;/li&gt;
	&lt;li&gt;the chip name can now be used as a variable&lt;/li&gt;
	&lt;li&gt;it&apos;s consistent with the naming we used in SDSS&lt;/li&gt;
	&lt;li&gt;while this change means that filenames will sort differently, as the main sort key is usually the visit the 12 files associated with a visit will still be together, and we feel that this is acceptable.&lt;/li&gt;
&lt;/ol&gt;


&lt;p&gt;We will also need to switch the last two digits in raw file names (e.g. PFSA files);  Craig and I agree that this is worth it at this point in the project where he owns all the raw data.&lt;/p&gt;

&lt;p&gt;N.b. This is our last opportunity to make this change;  once we&apos;ve started taking data at LAM we are frozen for the rest of the life of the instrument.&lt;/p&gt;</description>
                <environment></environment>
        <key id="11315">DAMD-12</key>
            <summary>Change order of spectrograph and arm in data model from e.g. 1r to e.g. r1</summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="3" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/major.svg">Major</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="-1">Unassigned</assignee>
                                    <reporter username="rhl">rhl</reporter>
                        <labels>
                    </labels>
                <created>Thu, 10 Nov 2016 22:20:59 +0000</created>
                <updated>Thu, 27 Jul 2017 14:32:44 +0000</updated>
                            <resolved>Thu, 27 Jul 2017 14:32:44 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>5</watches>
                                                                <comments>
                            <comment id="11538" author="naoyuki.tamura" created="Fri, 11 Nov 2016 09:41:17 +0000"  >&lt;p&gt;I fully understand and agree that the consistency is critical. But perhaps I still don&apos;t fully understand the main reason for the swap of the last two digits. Being the same as SDSS is it? Or Craig already created valuable output files from the PFS detectors with them swapped?&lt;/p&gt;</comment>
                            <comment id="12444" author="rhl" created="Wed, 26 Jul 2017 21:45:54 +0000"  >&lt;p&gt;Well, shall we do it? (I&apos;m working on camera description files, so now&apos;s the time).&lt;/p&gt;

&lt;p&gt;Craig: note the comment&lt;br/&gt;
&amp;gt; We will also need to switch the last two digits in raw file names (e.g. PFSA files)&lt;/p&gt;</comment>
                            <comment id="12446" author="atsushi.shimono" created="Thu, 27 Jul 2017 01:00:06 +0000"  >&lt;p&gt;I don&apos;t against to swap pfsArm definition (or I&apos;d say point 4 seems reasonable), but I don&apos;t feel swapping two for PFSA* is a good idea. Two identifiers are in &quot;%1d%1d&quot; not like pfsArm&apos;s &quot;%1s%1d&quot;, so all 8 digits are in the same character category. For these, it seems for me to be natural with following organization, such as visit -&amp;gt; spectrograph -&amp;gt; arm.&lt;/p&gt;</comment>
                            <comment id="12447" author="cloomis" created="Thu, 27 Jul 2017 01:18:53 +0000"  >&lt;p&gt;I vote for leaving the raw camera files as-is (spectrograph-arm), and making all subsequent files arm-spectrograph (&quot;r1&quot;). &lt;/p&gt;

&lt;p&gt;Besides the DRP ingestion step, the only systems which handle raw files are in the instrument realm, where the hierarchy (instrument-spectrograph-dewar) is significant and makes sense. &lt;/p&gt;

&lt;p&gt;All other files are in the realm of DRP, where it can be more convenient to use names like &quot;r1&quot;.&lt;/p&gt;</comment>
                            <comment id="12451" author="rhl" created="Thu, 27 Jul 2017 14:32:44 +0000"  >&lt;p&gt;OK, I&apos;m going to adopt this:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;Raw filenames remain &lt;tt&gt;PFXYVVVVVVSA.fits&lt;/tt&gt; (&lt;tt&gt;V&lt;/tt&gt;: Visit &lt;tt&gt;S&lt;/tt&gt;: Spectrograph# &lt;tt&gt;A&lt;/tt&gt;: Arm#&lt;/li&gt;
	&lt;li&gt;All other files are named by &lt;tt&gt;as&lt;/tt&gt;:  &lt;tt&gt;a&lt;/tt&gt;: arm name  &lt;tt&gt;s&lt;/tt&gt;: spectrograph number&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;E.g. pfsArm-002026-r1.fits&lt;/p&gt;

&lt;p&gt;I will update the data model code to support this convention, but it will take a modification to the &quot;Hirata&quot; simulator to see this change (specifically we&apos;ll have to change which version of the data model product it pulls in as a git submodule)&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10000">
                    <name>Blocks</name>
                                            <outwardlinks description="blocks">
                                        <issuelink>
            <issuekey id="11314">PIPE2D-118</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|031vid:xi0r</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>