https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-119 Data Model <p>Datamodel.txt specifies that positions in the focal plane are specified in microns. On the Sept 2021 run (the first time we really designed pfsDesign files) we used mm, and on reflection this makes sense at those are the units used in PFI geometry.</p> <p>I propose that we make this official, but am of course open to counter arguments.</p> DAMD-119

Change datamodel.txt to specify pfiNominal/pfiCenter mm, not microns

Story Normal Done Done hassan rhl Wed, 22 Sep 2021 21:36:46 +0000 Tue, 2 Nov 2021 03:10:28 +0000 Tue, 2 Nov 2021 03:10:28 +0000 0 5 <p>As the original author, I agree with the proposed change.</p> <p>No objections to the proposal from the DRP (meeting 2021-09-24).</p> <p>I suggest not bumping the <tt>DAMD&#95;VER</tt> because this change doesn't affect pfsConfig files in the wild; if we do bump the <tt>DAMD&#95;VER</tt>, we should use <tt>DAMD&#95;VER</tt> to modify values on read.</p> <p>There's an associated trivial change needed <a href="https://github.com/Subaru-PFS/drp_instmodel/blob/master/python/pfs/instmodel/makePfsConfig.py#L103" class="external-link" rel="nofollow">in drp&#95;instmodel</a>.</p> Development Rank 0|zzs9vc: Reviewers price Sprint 2DDRP-2021 A 10 2DDRP-2021 A11 Story Points 1.0