https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-110 Data Model <p>it would be nice to know to which MTP belong a given fiber. <br/> at least when the flux uniformity across the slit is checked at LAM we do need this.</p> DAMD-110

Add mapping of fibre to MTP connector to pfsConfig/Design

Task Normal Done Done rhl fmadec Tue, 27 Apr 2021 14:41:44 +0000 Mon, 28 Jun 2021 23:16:03 +0000 Mon, 28 Jun 2021 23:16:03 +0000 0 6 <p>That is in the GFM file, though encoded in a slightly non-obvious way.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a> How should we do this? Adding an extra column to the DESIGN/CONFIG tables would probably be best, but we'll have to think about backwards compatibility.<br/> There was also talk about adding a relative transmission for each fibre (e.g. 3 is c. 10% due to a Cable A problem), should we do that at the same time? Currently there's just a binary decision "Is fibre <tt>BLOCKED</tt>?"</p> <p>I think we need it in the pfsConfig as it looks as if e.g. we may need this information for sky subtraction.</p> <p>I don't see the need to have it in the <tt>pfsConfig</tt> if it's in pfs&#95;utils (<tt>pfs.utils.fiberids.FiberIds</tt>) and static. But if it's not static, then we need a way of minimally choosing the correct configuration.</p> <p>Having the relative transmission might be nice (though it's theoretically available through the <tt>fiberProfiles</tt>), but again I don't see the need to put it in the <tt>pfsConfig</tt>.</p> <p>Currently the pipelines don't use anything accessed via <tt>pfs_utils</tt>, and I think it makes things more complicated if we have to start doing so. My concern is what we should do if MTPs move together (and I think that there's evidence for that).<br/> If it's just Fabrice in his lab, then I agree that documenting the interface for him would probably be enough.</p> <p>We already <a href="https://github.com/Subaru-PFS/pfs_pipe2d/blob/master/bin/build_pfs.sh#L88" class="external-link" rel="nofollow">distribute pfs&#95;utils along with the 2D pipeline</a>, and we use it to create <tt>pfsDesign</tt> files for DCB (<tt>makeDummyCableBDesign.py</tt>).</p> <p>I think we agreed in a recent meeting that using the mapping in pfs&#95;utils is sufficient. I propose closing this <tt>WONTFIX</tt>.</p> <p>well</p> <p>if so can we be sure that we have the proper API with pfs_utils and so a proper ticket? <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a> ?</p> <p>OK. Let me check. If there is missing/failing functionality I will file a new ticket.</p> <p>I'm working on this (that is, I wrote the code). I assume that the name we want is e.g. <tt>D1-3-1</tt> </p> <p>D1-3 tell us which mtp but not which fiber in the mtp connector, if I am correct</p> <p>D1-3-&lt;specId&gt;-&lt;mtp position&gt; <br/> it would be nice to have also the position in case we identify fiber that show bad illumination (as we did on SM1)</p> <p>There are 4 of values per fibre (A, BA, BC, and C).  So do you want me to return</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> (<span class="code-quote">"D0-1-1"</span>, (2, 26, 31, 7)) </pre> </div></div> <p>or something else?</p> <p>Or just the 4 raw strings, including the cobra number?</p> <p>it may be worth to have the complete information, no ?<br/> or we could have different option that returns different information ?</p> <p>for my perspective I only need which mtp and position on Cable A but... so D0-1-x-26 for example or simply DO-1 according what I am looking for (mtp only for this last example)</p> <p>As discussed during the DRP telecon on 2021-06-04, this functionality will be implemented in pfs_utils, not the datamodel. <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1288" title="Provide a function to map fiberIds to MTP connectors" class="issue-link" data-issue-key="INSTRM-1288"><del>INSTRM-1288</del></a> covers that work.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> Return MTP information <span class="code-keyword">for</span> the specified fiberIds Args ---- fiberIds : array of 1-indexed fiberIds pfsConfig : `pfs.datamodel.PfsConfig` Tell us e.g. which fibres go to SuNSS Returns ------- an array of (<span class="code-quote">"MTPID"</span>, (holes), cobraId) where <span class="code-quote">"holes"</span> are <span class="code-keyword">for</span> the A, BA, BC, and C connectors, and cobraId is the 0-indexed global cobra ID For SuNSS, the <span class="code-quote">"cobra ID"</span> is negative, and its absolute value is the ID in the ferrule (<span class="code-keyword">for</span> the imaging leg) or 127 + ID (<span class="code-keyword">for</span> the diffuse leg) </pre> </div></div> <p>The usage is:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-python"> <span class="code-keyword">import</span> lsst.daf.persistence <span class="code-keyword">as</span> dafPersist <span class="code-keyword">import</span> pfs.utils.fiberids <span class="code-keyword">as</span> fiberids butler = dafPersist.Butler(<span class="code-quote">"/projects/HSC/PFS/Subaru"</span>) dataId = <span class="code-object">dict</span>(visit=45783, arm=<span class="code-quote">"r"</span>, spectrograph=1) pfsConfig = butler.get(<span class="code-quote">'pfsConfig'</span>, dataId) fiberIds = fiberids.FiberIds() fiberIds.fiberIdToMTP(pfsConfig.fiberId, pfsConfig)[100] </pre> </div></div> <p>which returns</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> (<span class="code-quote">'U1-2-1'</span>, [26, 2, 7, 31], -51) </pre> </div></div> <p>(where <tt>-51</tt> indicated an imaging SuNSS "cobra").</p> <p>Pushed to tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-110" title="Add mapping of fibre to MTP connector to pfsConfig/Design" class="issue-link" data-issue-key="DAMD-110"><del>DAMD-110</del></a></p> <p>Proposed changes in branch look fine.</p> <p>Merged to master.</p> Duplicate INSTRM-1259 Relates INSTRM-1258 INSTRM-1288 Development Rank 0|02qpt6:508yl0chzzy0000026r Sprint 2DDRP-2021 A 4 2DDRP-2021 A5 2DDRP-2021 A 6 Story Points 2.0