https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-11 Data Model <p>The 2d pipeline needs a seed solution for fiber positions and wavelengths, both to identify the fiber traces and to initialize the wavelength solution for arc line matching. The simulator knows the geometry from the input jemax spot files and is currently supplying stella with a one-off (fiber#, y) -&gt; (x, lambda) FITS table.</p> <p>We would like to use proper datamodel files to encapsulate the table. There is an existing <a href="https://github.com/Subaru-PFS/datamodel/blob/master/python/pfs/datamodel/pfsFiberTrace.py" class="external-link" rel="nofollow">pfsFiberTrace</a> file which can hold the (fiber#, y) -&gt; x mapping, but it does not have space for wavelength info.</p> <p>Surely we want to persist wavelength solutions outside of pfsArm files, since the maps will get applied to several image files. </p> <p>Not sure whether we should:<br/> 1. create some pfsFiberWaves file, which just contains the (fiber#, y) -&gt; lambda map. <br/> 2. beef up the existing file by adding an optional HDU containing a wavelength column for the PHDU table.</p> <p>Now that I write it down, 2 looks too gross. So 1? Shall I?</p> DAMD-11

Create or adapt file to include per-fiber+row wavelengths.

Task Major Done Done aritter cloomis Wed, 9 Nov 2016 23:31:08 +0000 Fri, 11 May 2018 20:44:08 +0000 Fri, 11 May 2018 20:44:08 +0000 0 3 <p>I thought we had agreed on adding the (fiber#,y)-&gt;lambda map to the existing pfsFiberTrace file, which I can easily do if you give me the map. Is there any difference between this map and the file you created for <a href="https://pfspipe.ipmu.jp/jira/browse/SIM2D-68" title="Please recreate file containing predicted wavelengths for each pixel in each fiber trace" class="issue-link" data-issue-key="SIM2D-68"><del>SIM2D-68</del></a>? Isn't the map part of <a href="https://pfspipe.ipmu.jp/jira/browse/SIM2D-68" title="Please recreate file containing predicted wavelengths for each pixel in each fiber trace" class="issue-link" data-issue-key="SIM2D-68"><del>SIM2D-68</del></a>?</p> <p>As much as I'd like to for neatness sake, putting the lambda map in ``pfsFiberTrace`` files would require two forms of the ``pfsFiberTrace`` file, because of the order in which new flats and arcs are measured, and that the file would need to be rewritten or appended to. Basically, the lambda map would be different before and after the arc exposure is processed.</p> <p>If anyone can think of a clean way of dealing with this it'd be great. I assert that rewriting FITS files is evil, though. Hence some ``pfsFiberWaves`` file just to hold the new arc solution, which was measured using the traces from the ``pfsFiberTrace`` file.</p> <p>The hack version I emailed you is essentially the same as the earlier version. I bumped the ``xc`` and ``pixelWave`` columns to doubles, and dropped the entirely redundant ``yc``.</p> <p>I think I proposed that the command would take both the flat(s) and the arc(s) and solve both problems before performing any output. Does this solve your problem?</p> <p>Is the proposal that we would then have:</p> <ul class="alternate" type="square"> <li>``pfsFiberTrace`, which contains the position information extracted from the fiber flats</li> <li>no file for only the wavelength solution, because that would go directly into the:</li> <li>``pfsFiberMap``/``pfsFiberSolution``/something which would contain both the fiber positions and wavelengths, and would thus be all that is needed to reduce a science file.</li> </ul> <p>Is that what you have in mind? Is there any scenario where the arc extraction process would modify/tweak the fiber traces?</p> <p>I think what RHL has in mind is to put everything into the pfsFiberTrace file which would be created by one command that extracts the FiberTraces from the Flats and the wavelength solution from the Arcs. In this case no re-writing or appending is required. I guess that would mean that we have one seed pfsFiberTrace file from the simulations which is read in as a 'guess' by the task which produces the output pfsFiberTrace file.</p> <p>Since stella both generates and consumes the wavelength solution I think it would make more sense for Andreas/Stella to make the datamodel additions &#8211; I'd have to guess at some implementation details.</p> <p>Following discussions with <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a>, the DetectorMap addresses this.</p> Development Rank 0|031vid:xi07fhk0s