https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/DAMD-101 Data Model <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=Martin.Reinecke" class="user-hover" rel="Martin.Reinecke">Martin Reinecke</a> points out that the outputs of shuffle need to be saved somewhere, and this should be added to the datamodel. We'd want to know at least the position <tt>(ra, dec)</tt>, proper motion/parallax, magnitude, colour, which AG, and AG <tt>(x, y)</tt>. The metadata will need to know the design epoch and telescope elevation (maybe 2020 and zenith).</p> <p>One option would be to add an extra HDU to the pfsDesign file.</p> <p>We also need to worry about refraction, so we'll need to update the <tt>(x, y)</tt> at the time that we generate the <tt>pfsConfig</tt> file; this suggests that the <tt>pfsDesign</tt> proposal is a good way to go.</p> DAMD-101

Save the outputs of shuffle

Story Normal Done Done hassan rhl Fri, 11 Dec 2020 14:15:39 +0000 Thu, 6 May 2021 23:11:22 +0000 Tue, 20 Apr 2021 18:32:30 +0000 0 5 <p>Hi <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a> </p> <p>Reading the current draft, do we need a guide star identifier (e.g. Gaia source ID?) in GUIDESTARS table so that we go back to the original catalogue easily? This may perhaps be an identifier in our database to pool target and guide star <em>candidates</em> to be observed.</p> <p>I also noticed that the HDU number for "PHOTOMETRY" was probably wrong in both `pfsDesign` and `pfsConfig`.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> HDU #0 PDU HDU #1 FITS binary table named <span class="code-quote">"DESIGN"</span> HDU #1 FITS binary table named <span class="code-quote">"PHOTOMETRY"</span></pre> </div></div> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> HDU #0 PDU HDU #1 FITS binary table named <span class="code-quote">"CONFIG"</span> HDU #1 FITS binary table named <span class="code-quote">"PHOTOMETRY"</span></pre> </div></div> <p> </p> <p> </p> <p>{{shuffle }}executes coordinate transforms in the "sky_pfi" mode. For this to work, accurate time information is necessary, at least with the currently available interface. It may be possible to get away with the elevation angle alone, but I'm not really sure about that.</p> <p>Or is the idea to run shuffle in two different modes: once for rough planning, where the exact observation time doesn't matter because we don't care about differential refraction, and then again once the observation time is known, so it produces exact position data for the guide star candidates?</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe" class="user-hover" rel="kiyoto.yabe">Kiyoto Yabe</a> and <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=Martin.Reinecke" class="user-hover" rel="Martin.Reinecke">Martin Reinecke</a>: I've made <a href="https://github.com/Subaru-PFS/datamodel/commit/be5f056ae77c52b6117468299d340e54211bf84f" class="external-link" rel="nofollow">updates</a> to the proposed <tt>GUIDESTARS</tt> HDU based on your recent comments. Have a look and tell me if there are additional changes needed.</p> <p>Further <a href="https://github.com/Subaru-PFS/datamodel/commit/2a92daf67e2fd5ed0c5ee1cb1959a6275b5f1ae3" class="external-link" rel="nofollow">updates</a> made following comments from <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a>.</p> <p>Looks good to me, provided we find a way to compute the coordinate transforms  given only an elevation angle.</p> <p>Looks good to me, too. I'm still thinking about how to deal with this in opDB but it should be discussed in <a href="https://pfspipe.ipmu.jp/jira/browse/FIBERALLOC-34" class="external-link" rel="nofollow">FIBERALLOC-34</a>.</p> <p>We need tests of the <tt>GuideStars</tt> class (I/O in particular, but would also be good to check that incorrect lengths get caught), and I don't think it's a good idea to allow <tt>guideStars=None</tt> in the ctor (the user should be forced to think about what he wants).</p> <p>If there are any additional changes needed, new tickets should be filed.</p> Relates DAMD-112 Development Rank 0|02qpt6:508yl0chzzy0000099 Reviewers price Sprint 2DDRP-2021 A 2 2DDRP-2021 A3 2DDRP-2021 A 4 Story Points 3.0