[SIM2D-95] Interface to target spectra library Created: 30/Jan/19 Updated: 05/Apr/19 Resolved: 05/Apr/19 |
|
| Status: | Done |
| Project: | DRP 2-D Simulator |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.0 |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Story Points: | 2 | ||||||||
| Sprint: | 2DDRP-2019 C | ||||||||
| Reviewers: | hassan | ||||||||
| Description |
|
Sean Johnson will provide a library of target spectra that we want the Simulator to use. Until that is ready, the Simulator has been hard-wired to produce flat F_nu spectra. Once the library has been delivered, we need to have the Simulator pull spectra from the library. |
| Comments |
| Comment by rhl [ 08/Mar/19 ] |
|
By "hard wired" do you mean that the input pfsSimObject files all represent flat F_nu objects? If not, can't we complete the book-keeping without waiting for Sean? |
| Comment by price [ 08/Mar/19 ] |
|
By "hardwired", I mean that the input spectrum regardless of objId is a flat F_nu object. There's no file backing those. I believe the bookkeeping has been taken care of already, and we're just waiting to make the switch once the spectra are delivered. |
| Comment by rhl [ 08/Mar/19 ] |
|
How hard is it to make a file of the proper input format? Are the arcs and sky also hard-wired (I seem to remember some horrors with the sky). Is there a ticket for Sean to provide the "real" spectra?
|
| Comment by price [ 23/Mar/19 ] |
|
Here's a simulated galaxy spectrum from Sean Johnson after it's been inserted into the 2D simulator and run all the way through the pipeline. You can see the Balmer break and [OII] at 757.5nm, so z=1.03. from lsst.daf.persistence import Butler butler = Butler("/home/pfs/pfs/sim2d-95/INTEGRATION/rerun/integration/pipeline") spectrum = butler.get("pfsCoadd", catId=1, tract=0, patch="0,0", objId=0x12, numExp=4, expHash=0x1eab2e92) fig, axes = spectrum.plot(plotSky=False, plotErrors=False, show=True) |
| Comment by price [ 23/Mar/19 ] |
|
Here's how I ran the simulator: pfs@0f30f57bf254:~/pfs/SIMS/raw $ makePfiDesign --fibers lam --pfiDesignId 1 --scienceCatId 1 --scienceObjId "18 55 71 76 93 94 105 112 115" pfs@0f30f57bf254:~/pfs/SIMS/raw $ makePfiDesign --fibers lam --pfiDesignId 2 --scienceCatId 1 --scienceObjId "18 55 71 76 93 94 105 112 115" pfs@0f30f57bf254:~/pfs/SIMS/raw $ makeSimRun 1 2 Of course, more extensive simulations will require a lot more work to build the necessary PfsDesign files: this is just building two exposures, each with 7 science objects (plus 2 sky and 1 flux standard). |
| Comment by price [ 23/Mar/19 ] |
|
I believe this is ready for review. Once it merges, I'll provide a build on tiger and instructions on how to run it. |
| Comment by price [ 01/Apr/19 ] |
|
hassan: I think you signed off on this on GitHub. Is it OK to merge? |
| Comment by hassan [ 02/Apr/19 ] |
|
Yes, sorry. I've changed the status to 'Review Complete'. |
| Comment by hassan [ 05/Apr/19 ] |
|
price: feel free to merge so that this ticket can be closed. |
| Comment by price [ 05/Apr/19 ] |
|
Merged to master. |