[SIM2D-31] Simulate flat field lamp spectra Created: 16/Jul/14  Updated: 19/Sep/19  Resolved: 19/Sep/19

Status: Done
Project: DRP 2-D Simulator
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Major
Reporter: rhl Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
is blocked by INFRA-4 Define format for persistence of 1-D ... Won't Fix
Epic Link: Simulated spectra
Reviewers: hassan

 Description   

The flat field lamps will be incandescent lamps with a filter to approximate a black body at c. 5000K.



 Comments   
Comment by price [ 12/Sep/19 ]

Just needed to adjust the temperature. The changes are trivial:

price@price-laptop:~/pfs/drp_instmodel (tickets/SIM2D-31 *$%=) $ git sub-patch
commit ce712b0cde22da128e6be9e8492e7da875017fb8 (HEAD -> tickets/SIM2D-31, origin/tickets/SIM2D-31)
Author: Paul Price <price@astro.princeton.edu>
Date:   Wed Sep 11 12:45:49 2019 -0400

    FlatSpectrum: set temperature to 5000 K
    
    as specfied by RHL.
    
    This requires a slight adjustment of the scaling as well to
    avoid saturating the detectors.

diff --git a/python/pfs/instmodel/spectrum.py b/python/pfs/instmodel/spectrum.py
index a190431..ffdabea 100644
--- a/python/pfs/instmodel/spectrum.py
+++ b/python/pfs/instmodel/spectrum.py
@@ -173,12 +173,12 @@ class FlatSpectrum(Spectrum):
     scale : `float`
         Scale to apply to spectrum.
     """
-    def __init__(self, scale=2.0e-19):  # Scale chosen manually to get reasonable counts in 30 sec
+    def __init__(self, scale=7.0e-20):  # Scale chosen manually to get reasonable counts in 30 sec
         self.scale = scale
 
     def interpolate(self, wavelength):
         """return a quartz lamp spectrum, as seen by our detector."""
-        return self.scale*blackbody(wavelength, 3800.0)
+        return self.scale*blackbody(wavelength, 5000.0)
 
 
 class LineSpectrum(Spectrum):
Comment by hassan [ 18/Sep/19 ]

Changes look fine from the diff. But you don't want to raise a pull request?

Comment by price [ 18/Sep/19 ]

The changes are trivial, and the diff is pasted above. Do you need a GitHub PR?

Comment by hassan [ 18/Sep/19 ]

No, your approach is fine for this one. I should have made that clear in my last message. I'll mark this as review-complete.

Comment by price [ 19/Sep/19 ]

Merged to master.

Generated at Sat Feb 10 16:07:52 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.