[SIM2D-140] NIR throughput data: wavelengths >1000nm are truncated Created: 10/Jul/21  Updated: 18/Aug/21  Resolved: 22/Jul/21

Status: Won't Fix
Project: DRP 2-D Simulator
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Critical
Reporter: hassan Assignee: hassan
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks PIPE2D-849 Provide pipeline output for simulated... Done
Relates
relates to PIPE2D-886 Generate a new weekly dataset Done
Story Points: 1
Sprint: 2DDRP-2021 A 7

 Description   

The wavelengths in the NIR throughput data

https://media.githubusercontent.com/media/Subaru-PFS/drp_instdata/master/data/throughput/pfs_thr_20151204_ext_all_nir.dat

above 1000nm are truncated to 3 significant digits, which means the 0.1 nm linear step size is lost for wavelengths greater than 1000nm:

[...]
9.996e+02  
9.997e+02 
9.998e+02 
9.999e+02  
1.000e+03  
1.000e+03  
1.000e+03  
1.000e+03  
1.001e+03 
1.001e+03
[...]

This causes makeSim to fail, as the interpolation code therein expects the wavelengths to be strictly monotonically rising.

Fix these data.



 Comments   
Comment by Kiyoto Yabe [ 10/Jul/21 ]

This is my mistake. I'll fix that.

On the otherhand, should we update them so that they are consistent with the latest ETC?

Comment by hassan [ 10/Jul/21 ]

I've fixed it already. I suggest updating them should be as part of a separate ticket.

Comment by Kiyoto Yabe [ 10/Jul/21 ]

OK, thank you.

Comment by hassan [ 22/Jul/21 ]

Superseding changes made by Yabe-san as part of SIM2D-132.

Generated at Sat Feb 10 16:08:59 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.