[SIM2D-132] Incorporate updated ETC throughput Created: 09/Feb/21 Updated: 29/Jan/22 Resolved: 23/Jul/21 |
|
| Status: | Done |
| Project: | DRP 2-D Simulator |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Reviewers: | hassan | ||||||||||||
| Description |
|
Kiyoto Yabe has updated the throughput model for the ETC. We should update the 2D simulator to match. Best would be to use the same files as in the ETC. |
| Comments |
| Comment by price [ 17/Jul/21 ] |
|
Throughput data is in spt_ExposureTimeCalculator/python/config/. But it is sampled every 10nm instead of every 0.1nm, and it doesn't seem to have the "throughput without atmosphere" column populated. |
| Comment by Kiyoto Yabe [ 21/Jul/21 ] |
| Comment by price [ 21/Jul/21 ] |
|
I've updated drp_instmodel to use the new data and checked that it works. |
| Comment by hassan [ 21/Jul/21 ] |
|
Thanks. Review complete based on Paul's checks above. |
| Comment by price [ 21/Jul/21 ] |
|
Merged. Thanks for doing all the hard work, Kiyoto Yabe! |