[SIM2D-117] Use PfsDesign not PfiDesign Created: 27/May/19 Updated: 27/Jun/19 Resolved: 01/Jun/19 |
|
| Status: | Done |
| Project: | DRP 2-D Simulator |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | Kiyoto Yabe | Assignee: | hassan |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 2 | ||||||||
| Sprint: | 2DDRP-2019 F | ||||||||
| Reviewers: | price | ||||||||
| Description |
|
I'm now trying pipe2d 5.0.3 and the current drp_instmodel. Since the datamodel was updated, I got an error saying "cannot import PfiDesign" for makePfiDesign and makeSim. Please update them as consistent with the current datamodel. |
| Comments |
| Comment by hassan [ 01/Jun/19 ] |
|
Code updated by renaming all references to pfiDesign to pfsDesign. Note that makePfiDesign has been renamed to makePfsDesign. Code tested (by running makeSim) against pipe2d 5.0.3 as follows:
makePfsDesign --fibers lam --pfiDesignId 1 --scienceCatId 1 --scienceObjId "5270"
makeSim --detector r1 --exptime 900 --expId 32 --imagetyp OBJECT --allOutput --pfsDesignId 1 --pfsConfig
|
| Comment by hassan [ 01/Jun/19 ] |
|
Merged to master (030c402). |