[REDMINE1D-91] [RM-8113] [linemeas] Review minimum OverlapThreshold (33%) for lines outside lambdarange Created: 13/Jun/23 Updated: 12/Jan/24 |
|
| Status: | Open |
| Project: | 1D Redmine |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | Redmine-Jira Migtation | Assignee: | Redmine-Jira Migtation |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Description |
|
Created on 2023-06-06 08:53:44 by Mira Sarkis. % Done: 0 @m_OutsideLambdaRangeOverlapThreshold@ is hardcoded to 33% which is too small. Todo: remove the hardcoded value in @CLineModelElement@ and add a new corresponding parameter. Check run: /net/CESAM/amazed/msarkis/GEWG_50K_2020_8102/output_0.42_linemeasFitGaussien with lbdaRange.max = 12500. Other spectra with similar problem: 00001517, 00009358, 00018571, 00030199,00054383 |
| Comments |
| Comment by Redmine-Jira Migtation [ 12/Jan/24 ] |
|
Comment by Didier Vibert on 2023-06-15 10:03:31:
|
| Comment by Redmine-Jira Migtation [ 12/Jan/24 ] |
|
Comment by Didier Vibert on 2024-01-11 13:50:33: |
| Comment by Redmine-Jira Migtation [ 12/Jan/24 ] |
|
Comment by Vincent Le Brun on 2024-01-11 13:53:44: ben oui. Et comme il semblerait que la couverture spectrale de NISP soit un peu plus grande que prévue, on a un peu de marge si le range en redshift n'est pas modifié |
| Comment by Redmine-Jira Migtation [ 12/Jan/24 ] |
|
Comment by Didier Vibert on 2024-01-11 13:56:17: ok pour le range en z, cette issue devrait aussi prendre en compte les trous dans la couverture en longueurs d'onde (cf #7982) |