[REDMINE1D-396] [RM-8634] vérification du lambda range Created: 03/Feb/24  Updated: 08/Feb/24

Status: In Progress
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2024-02-02 10:34:13 by Vincent Le Brun. % Done: 100

sur les spectres JWST (donc que je n'ai pas le droit de regarder) les longueurs d'onde étaient en nm dans les spectres, donc il y avait une intersection nulle entre les spectres et le lambda range, et le errors.csv contenait le message
STAGE_NOT_RUN_BECAUSE_OF_PREVIOUS_FAILURE not run because init failed INVALID_SPECTRUM "Failed to validate spectrum flux: all values are zeroes.
pour tous les spectres

 Comments   
Comment by Redmine-Jira Migtation [ 08/Feb/24 ]

Comment by Didier Vibert on 2024-02-05 15:20:22:
je confirme, la librairie ne fait pas les choses dans le bon ordre, elle valide le spectre (dans le lambda range sans tester s'il intersecte le spectre sur au moins un sample) et ne fait ce test qu'ultérieurement.

Je corrige dans la foulée... vu que l'analyse du problème constitue 90% du travail !

Comment by Redmine-Jira Migtation [ 08/Feb/24 ]

Comment by Didier Vibert on 2024-02-06 17:55:57:
MR: https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/584

Comment by Redmine-Jira Migtation [ 08/Feb/24 ]

Comment by Didier Vibert on 2024-02-07 08:40:04:
note: I used boost::tuple compatibility with C++17 strucutred binding which is available only since boost 1.74

=> need to upgrade the minimal version of boost for pylibamazed

Comment by Redmine-Jira Migtation [ 08/Feb/24 ]

Comment by Didier Vibert on 2024-02-07 14:33:48:
Didier Vibert wrote in #note-3:
> note: I used boost::tuple compatibility with C++17 strucutred binding which is available only since boost 1.74
>
> => need to upgrade the minimal version of boost for pylibamazed

I added an include file to cope with boost < 1.74 (to be removed when minimal boost version required will be > 1.74)

Generated at Sat Feb 10 15:32:18 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.