Comment by Pierre-yves Chabaud on 2024-01-11 16:39:08:
*Added*

• The API now handles multiple lsf
• In full multiobs, Amazed provides now one model per observation
• "not and" operator have been added to filtering feature
• A warning is raised when lambda range is clamped (it occurs when user lambda range is not compliant with the lambda grid of the input spectrum)
• String vectors type are now available in Amazed output
• The flux uncertainty with direct integration method is now available in Amazed output

*Changed*

• Change line ID as line number in linecatalog, ensuring uniqueness of line name, wavelength (rounded to 2 decimals) and type (E or A)
• Change version of LBFGSpp to v0.3.0
• Changes the way of dealing with redshifts candidates with overlapping integration ranges. In case of overlap greater than 30%, only the best candidates (i.e. highest proba) is selected. In other case, the overlap is equally splitted and candidates are both kept

*Deprecated*

*Removed*

*Fixed*

• The linemeas method is no more executed when redshift solver has failed
• Better protect bad calibration directory content from segfault, and raise informative exceptions
• Line ratio amplitude of absorption lines and Lya asym parameters have been fixed in the photometric model

Comment by Didier Vibert on 2024-01-12 11:03:33:
Pierre-yves Chabaud wrote in #note-2:
> *Added*
>
[commentaire: il manque l'ajout du checker de paramètre]

• The API is now checking the syntax of the json input parameter file, raising an error if the syntax is wrong or if some required parameters are missing, issueing a warning for each unused parameter
  > * The API now handles multiple lsf
  included in each spectrum of a multi-obs
  ( but the current multi-obs in interleave mode is only able to handle one lsf: the first of the list is chosen)
  > * In full multiobs, Amazed provides now one model per observation
  > * "not and" operator have been added to filtering feature
  > * A warning is raised when lambda range is clamped (it occurs when user lambda range is not compliant with the lambda grid of the input spectrum)
  > * String vectors type are now available in Amazed output
  > * The flux uncertainty with direct integration method is now available in Amazed output
  >
  > *Changed*
  >
  > * Change line ID as line number in linecatalog, ensuring uniqueness of line name, wavelength (rounded to 2 decimals) and type (E or A)
  > * Change version of LBFGSpp to v0.3.0
  > * Changes the way of dealing with redshift candidates with overlapping integration ranges. In case of overlap greater than 30%, only the best candidates (i.e. highest proba) is selected. In other case, the overlap is equally splitted and candidates are both kept
  >
  [ il manque l'issue #8525 => modif des linecatalog et lineratio, peut être un recap à demander à @vlebrun]
  > *Deprecated*
  >
  > *Removed*
  >
  > *Fixed*
  >
  > * The linemeas method is no more executed when redshift solver has failed
  > * Better protect bad calibration directory content from segfault, and raise informative exceptions
  > * Line ratio amplitude of absorption lines and Lya asym parameters have been fixed in the photometric model
• output of fitted Line ratio main amplitude of absorption lines
• output of fitted Lya asym parameters
• output of fitted photometric model
• computation of cumulative SNR of strong emmission lines fixed and added a cumulative SNR al all emission lines

Comment by Pierre-yves Chabaud on 2024-01-16 15:13:13:
Last version to validate:

*Added*

• The API is now checking the syntax of the json input parameter file, raising an error if the syntax is wrong or if some required parameters are missing, issueing a warning for each unused parameter
• The API is now handling one lsf per observation (but the current multi-observation in interleave mode is only able to handle one lsf: the first of the list is chosen)
• In full multi-observation mode, Amazed provides now one model per observation
• "not and" operator have been added to filtering feature
• A warning is raised when lambda range is clamped (it occurs when user lambda range is not compliant with the lambda grid of the input spectrum)
• String vectors type are now available in Amazed output
• The flux uncertainty with direct integration method is now available in Amazed output
• The cumulative SNR for all emission lines is now available in Amazed output

*Changed*

• Change line ID as line number in linecatalog, ensuring uniqueness of line name, wavelength (rounded to 2 decimals) and type (E or A)
• Change version of LBFGSpp to v0.3.0
• Changes the way of dealing with redshifts candidates with overlapping integration ranges. In case of overlap greater than 30%, only the best candidates (i.e. highest proba) is selected. In other case, the overlap is equally splitted and candidates are both kept

*Deprecated*

*Removed*

*Fixed*

• The linemeas method is no more executed when redshift solver has failed
• Better protect bad calibration directory content from segfault, and raise informative exceptions
• The output of fitted Line ratio main amplitude of absorption lines is fixed
• The output of fitted Lya asym parameters is fixed
• The output of fitted photometric model is fixed
• The computation of cumulative SNR of strong emmission lines is fixed

Comment by Didier Vibert on 2024-01-16 15:50:27:
c'est bon pour moi

Comment by Pierre-yves Chabaud on 2024-01-17 08:59:13:
https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/573

Comment by Pierre-yves Chabaud on 2024-01-17 10:03:24:
Merged into @develop@ (@6f3e9a3a@)