[REDMINE1D-369] [RM-8536] [linemodel] force absorption lines to be null when continum under line is null or negative Created: 12/Dec/23  Updated: 07/Feb/24  Resolved: 07/Feb/24

Status: Done
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2023-12-11 15:29:24 by Didier Vibert. % Done: 100

in CLineModelFitting::GetModelSolution, to compute the absorbed flux one need to know the level of the continuum (since the fitted absorption amplitude in [0,1] is a fraction of this level). Currently this continuum level is measured on one pixel (the nearest from the line center). If this level is found negative, the absoprtion should be forced to null.

note: this appears essentially when setting the @continuumreestimation@ option (to "always" or "onlyextrema" )



 Comments   
Comment by Redmine-Jira Migtation [ 07/Feb/24 ]

Comment by Didier Vibert on 2024-01-26 15:45:17:
MR: https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/579

Comment by Redmine-Jira Migtation [ 07/Feb/24 ]

Comment by Didier Vibert on 2024-01-30 12:19:32:
pour les dev de clients (@aallaoui @gdaste @fdufresne) j'ai fait du renommage de quelques output dans le dernier commit de cette issue

Pouvez-vous regarder le diff de results_specification.csv dans ce dernier commit, et valider avant qu'on passe cette issue en feedback puis merge. Il faudra ensuite modifier les clients qui câblent les attributs renommés.

Comment by Redmine-Jira Migtation [ 07/Feb/24 ]

Comment by Didier Vibert on 2024-01-31 17:11:11:
IT full

Comment by Redmine-Jira Migtation [ 07/Feb/24 ]

Comment by Pierre-yves Chabaud on 2024-02-02 10:33:49:
Merged into @develop@ (@3f0393f1@)

Generated at Sat Feb 10 15:32:02 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.