[REDMINE1D-344] [RM-8433] [parameters] wrong enableIGM in load_linecatalog Created: 24/Oct/23  Updated: 10/Feb/24

Status: Review Complete
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2023-10-23 13:36:20 by Didier Vibert. % Done: 100

since #8048, inside load_linecatalog, the enableIGM boolean is wrongly computed

before #8048 the value was
<pre><code class="python">
enableIGM = self.parameters[object_type][method]["linemodel"]["igmfit"]
</code></pre>

whereas, now it is
<pre><code class="python">
enableIGM = self.parameters.get_solve_method_igm_fit(object_type, solve_method)
</code></pre>

and the code of @get_solve_method_igm_fit@ is
<pre><code class="python">
def get_solve_method_igm_fit(self, object_type: str, solve_method: str) -> bool:
igmfit = None
if solve_method == "LineModelSolve":
igmfit = self.get_lineModelSolve_igmfit(object_type)
elif solve_method == "TemplateFittingSolve":
igmfit = self.get_templateFittingSolve_igmfit(object_type)
elif solve_method == "TplcombinationSolve":
igmfit = self.get_templateCombinationSolve_igmfit(object_type)
return igmfit

</code></pre>

inside load_linecatalog, the @get_solve_method_igm_fit@ can be @"LineModelSolve"@ or @"LineMeasSolve"@

thus @"LineMeasSolve"@ is missing



 Comments   
Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Gaelle Daste on 2024-02-05 10:28:32:
MR : https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/583

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Gaelle Daste on 2024-02-05 14:02:30:
IT main OK

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Didier Vibert on 2024-02-05 15:29:38:
pour moi c'est bon. @fdufresne tu valides et met en feedback si c'est ok pour toi ?

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Fanny Dufresne on 2024-02-06 15:46:25:
OK pour moi, il faudra que je me rebase dessus, avec le refacto lya, le igmFit disparaƮt

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Pierre-yves Chabaud on 2024-02-09 17:46:46:
Merged into @develop@ (@d1a98494@)

Generated at Sat Feb 10 15:31:46 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.