[#REDMINE1D-343] [RM-8435] [parameters checker] add a dependance for asym Lya parameters

[REDMINE1D-343] [RM-8435] [parameters checker] add a dependance for asym Lya parameters Created: 24/Oct/23 Updated: 06/Feb/24
Status:	In Progress
Project:	1D Redmine
Component/s:	None
Affects Version/s:	None
Fix Version/s:	None

Type:

Task

Priority:

Normal

Reporter:

Redmine-Jira Migtation

Assignee:

Redmine-Jira Migtation

Resolution:

Unresolved

Votes:

Labels:

None

Remaining Estimate:

Not Specified

Time Spent:

Not Specified

Original Estimate:

Not Specified

Description

Created on 2023-10-23 14:56:03 by Didier Vibert. % Done: 50

all the parameters from @LineModelSolve.linemodel.lyafit@ section are necessary only if @LineModelSolve.linemodel.igmfit@ is False (and unused if True)

same for parameters @LineModelSolve.linemodel.lyaforcefit@ and @LineModelSolve.linemodel.lyaforcedisablefit@

note: the section lyafit is read by the instanciation of any fitter (see CAbstractfitter constructor code). We must add a test on the igmfit param to read or not this section (and set the corresponding members to NAN if we don't read).

BTW, in the @CAbstractFitter()@ constructor, these parameters should also be read if the method is @"LineMeasSolve"@. This is currently missing, and the linemeas solver is thus currently running through the Lya asymmetric profile fitting using the hardcoded default values for the parameters ranges and steps...
Note that the default parameter currently used for linemeas is igmfit false (for all parameters, notably the one delivered to PFS)

Thus we need to add the lyafit section in @LineMeasSolve@ with same dependance on igmfit.

Comments