[REDMINE1D-339] [RM-8422] [z prior] activate the unused zprior "nlines above snr 3.5" Created: 19/Oct/23  Updated: 20/Oct/23

Status: Open
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2023-10-18 09:54:53 by Didier Vibert. % Done: 0

There is a coded zprior that penalize the redshifts for which the solution contains less than 2 lines above SNR 3.5

This prior is not activated (hard coded) and has no dedicated parameter in the parameters.json (like the other z priors activation and strength) .

Shall we enable it and add the corresponding parameter, or remove the lines of code ?

According to me this is not strictly a "prior" in the sense that is based on observations, ie model fitting of the data. The likelihood (least-square term) of the posterior is supposed to handle all the attachment to the data term, where as the prior should only contain a priori information on the parameters...

Nevertheless, even is the term "prior" is improper, we may find that it is useful to enhance z solutions where lines are strong enough. This is more an ad hoc modification of the likelihood.



 Comments   
Comment by Redmine-Jira Migtation [ 20/Oct/23 ]

Comment by Vincent Le Brun on 2023-10-19 11:57:45:
we should test wether there is any case of wrong measurement with 2 emission lines at SNR>3.5 . in PFS simulations ? I don't expect many, so the prior might be useless

Generated at Sat Feb 10 15:31:43 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.