[REDMINE1D-325] [RM-8369] [api] Handle multiple LSF in AbstractSpectrumReader Created: 28/Sep/23  Updated: 14/Oct/23  Resolved: 14/Oct/23

Status: Done
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2023-09-27 15:11:29 by Thomas Bedrine. % Done: 100

Handling LSF in AbstractSpectrumReader isn't yet compatible with multiobs cases, and it is problematic with upcoming converted spectra from Euclid format (red and blue observations each have their own LSF for the same spectrum).
lsf_data should be a Container -> store multiple lsf
Remove API exception "Multiple LSF not handled" and choose arbitrarily one lsf to provide to the library
AbstractSpectrumReader.get_lsf should have an obs_id argument

 Comments   
Comment by Redmine-Jira Migtation [ 14/Oct/23 ]

Comment by Didier Vibert on 2023-09-27 15:24:27:
ne serais-ce pas un doublon de #6964 ? ou alors le but de ce ticket est différent ?

Comment by Redmine-Jira Migtation [ 14/Oct/23 ]

Comment by Thomas Bedrine on 2023-09-28 07:05:40:
J'en suis pas certain mais on en discutera à la réunion d'aujourd'hui pour savoir ce qu'on fait

Comment by Redmine-Jira Migtation [ 14/Oct/23 ]

Comment by Ali Allaoui on 2023-09-29 12:37:07:
lsf_data should be a Container -> store multiple lsf
Remove API exception "Multiple LSF not handled" and choose arbitrarily one lsf to provide to the library

Comment by Redmine-Jira Migtation [ 14/Oct/23 ]

Comment by Ali Allaoui on 2023-09-29 12:59:02:
lsf_data is a container of ndarray whatever the type of the lsf -> for gaussian constantwidth we have an ndarray with a column @width@ and one line

Comment by Redmine-Jira Migtation [ 14/Oct/23 ]

Comment by Ali Allaoui on 2023-09-29 13:23:51:
https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/547

Comment by Redmine-Jira Migtation [ 14/Oct/23 ]

Comment by Didier Vibert on 2023-10-05 13:23:58:
pou moi c'est bon, on peut passer en feedback

Comment by Redmine-Jira Migtation [ 14/Oct/23 ]

Comment by Pierre-yves Chabaud on 2023-10-06 14:54:16:
Merged into @develop@ (@e01bcee0@)

Generated at Sat Feb 10 15:31:35 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.