[REDMINE1D-314] [RM-8310] [linemodel] wrong output of some line ratio parameters Created: 21/Sep/23  Updated: 29/Sep/23  Resolved: 29/Sep/23

Status: Done
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2023-09-20 11:20:46 by Didier Vibert. % Done: 100

after the end of the loop on line-ratio, the method @CTplratioManager::finish@ should refresh the elements with the fitted values coming from the best line ratio.

  • -the amplitude is wrongly refreshed because all the nominal amplitudes were not refreshed...
    This has an impact on the computed model, and on the amplitude and flux of individual lines (including Ha complex and OII doublet). But the global amplitude and line ratio name are ok (since the call to @TLineModelResult::updateTplRatioFromModel@ at the end of @COperatorLineModel::buildExtremaResults@). The pdf and chisquare are ok too, with the redshift solution.-
  • the Lya asym parameters are not refreshed if the profile is ASYM (instead of ASYMFIT) because @CLine::SetAsymParams@ does nothing in ASYM case

maybe fixed by using LoadModelSolution

other bugs found:



 Comments   
Comment by Redmine-Jira Migtation [ 29/Sep/23 ]

Comment by Didier Vibert on 2023-09-20 13:26:54:
au temps pour moi, les amplitudes nominales (ie les line ratios) sont bien mises à jours à celle du meilleurs ratio en fin de boucle...

Comment by Redmine-Jira Migtation [ 29/Sep/23 ]

Comment by Didier Vibert on 2023-09-20 16:35:20:
MR: https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/545

Comment by Redmine-Jira Migtation [ 29/Sep/23 ]

Comment by Pierre-yves Chabaud on 2023-09-22 07:25:32:
Merged into @develop@ (@e6892294@)

Generated at Sat Feb 10 15:31:28 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.