[REDMINE1D-291] [RM-8235] set max number of candidates to retain after 1st pass to a dedicated parameter Created: 29/Aug/23  Updated: 07/Feb/24  Resolved: 07/Feb/24

Status: Done
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2023-08-28 09:56:21 by Didier Vibert. % Done: 100

the maximum number of first pass candidate to retain is hardcoded to 5.
(see https://gitlab.lam.fr/CPF/cpf-redshift/-/blob/0.44-RC4/RedshiftLibrary/src/lib/method/linemodelsolve.cpp?ref_type=tags#L506 and https://gitlab.lam.fr/CPF/cpf-redshift/-/blob/0.44-RC4/RedshiftLibrary/src/lib/method/linemodelsolve.cpp?ref_type=tags#L552)

it should be a dedicated parameter eg linemodel.firstpass.extremacount
This has to be a distinct parameter than the global one linemodel.extremacount, since we may want to have a bigger number in first pass than in final, for instance if we retain only one solution for saving disk space.

Then in the parameters checking, this parameter has to be greater than the global one.

 Comments   
Comment by Redmine-Jira Migtation [ 07/Feb/24 ]

Comment by Gaelle Daste on 2024-01-18 13:14:51:
MR : https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/574

Comment by Redmine-Jira Migtation [ 07/Feb/24 ]

Comment by Gaelle Daste on 2024-01-24 10:38:41:
J'ai fait tourner les ITs full et c'est OK

Comment by Redmine-Jira Migtation [ 07/Feb/24 ]

Comment by Pierre-yves Chabaud on 2024-02-06 11:18:43:
Merged into @develop@ (@0e9f5546@)

Generated at Sat Feb 10 15:31:14 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.