[REDMINE1D-261] [RM-8177] [Output] Some lines specified in results_specifications.csv are absent from output hdf5 Created: 12/Jul/23 Updated: 31/Jan/24 |
|
| Status: | In Progress |
| Project: | 1D Redmine |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | Redmine-Jira Migtation | Assignee: | Redmine-Jira Migtation |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Created on 2023-07-11 14:30:02 by Fanny Dufresne. % Done: 50 In results_specifications.csv, files some lines are present but not in the hdf5 output. Example: We could try to inventory those line and decide which ones we want to keep or not NB: to fix the presence of the two lines above, tplDtm and tplMtm are probably just missing from redshift.i struct CTplModelSolution + add missing elements in results_specifications.csv (those which are Firstpass<element> but missing <element> from second pass) |
| Comments |
| Comment by Redmine-Jira Migtation [ 31/Jan/24 ] |
|
Comment by Didier Vibert on 2023-07-17 12:32:31: dans le fichier d'interface swig et dans la def de la classe @CTplModelSolution@ les membres @tplDtM@ et @tplMtM@ existent bien, mais dans le @result_specification.csv@ ils sont mal orthographiés (m minuscule) ! On devrait aussi avoir les sorties suivantes manquantes avec le solver @TemplateFittingSolve@ et @LineModelSolve@: @ContinuumMtM@ @ContinuumDtM@ qui correspondent aux mêmes membres de la même classe C++ et mal orthographiés aussi. sur l'inventaire, le but est d'être exhaustif: tous les membres des classes dérivées de @COperatorResult@ ont vocation à être récupérables dans la lib python, possiblement en mode "extended" qu'il faut comprendre comme un mode "debug" . |
| Comment by Redmine-Jira Migtation [ 31/Jan/24 ] |
|
Comment by Didier Vibert on 2023-07-17 12:43:33: je confirme, ces sorties sont manquantes aussi. Finalement, la correction est simple: orthographier correctement ces sorties dans le fichier @results_specification.csv@ |
| Comment by Redmine-Jira Migtation [ 31/Jan/24 ] |
|
Comment by Didier Vibert on 2024-01-30 12:33:20: the missing output @ContinuumSNR@ (of second pass) has been added in #8536 But still need to check if there are others like that. |