[REDMINE1D-224] [RM-6548] cleaning after new ResultStore getters Created: 05/Jul/23  Updated: 24/Aug/23

Status: In Progress
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2021-06-22 13:42:41 by Didier Vibert. % Done: 66

after #6343 some more cleaning is necessary:

  • renaming of attribute names in hdf5 (possibly rename also the ResultStore class members)
  • scanning of all members in ResultStore classes, to track missing stuff to be added in HDF5 (at least in debug mode)
  • add first pass results from linemodel
  • implement debug mode filtering for writing HDF5
  • remove saving CPdfCandidateszResult<T> from ResultStore since it is now aggregated by inheritance in CExtremaResult<T> which is saved in ResultStore
  • break TCandidateZ inheritance from COperatorResult (feasible ?)
  • go deeper in python introspection, by enabling swig downcasting (casting a derived type from base class pointer) see: https://stackoverflow.com/questions/27392602/swig-downcasting-from-base-to-derived
  • more classes to differentiate COperatorResults derived classes
  • modify TLineModelResult(const CContinuumModelSolution& cms) constructor (and thus remove casscaded default empty ctor in the class hierarchy TLineModelResult->TExtremaResult()->TCandidateZ())
  • suppression du membre m_savedModelContinuumFittingResults de la classe CExtremaResult<TExtremaResult>
    (redondant avec le templating de CExtremaResult)
  • class CModelFittingResult, ctor use move semantic instead of copying the linemodelsolution
  • CModelFittingResult, redondancy (eg ::LineModelSolution.Fluxs & ::FitttedRaysFlux)
  • CModelFittingResult, add direct integ fluxes
  • COperatorLineModelExtremaResult::m_savedModelFittingResults,m_savedModelRulesResults, m_savedModelContinuumSpectrumResults, m_savedModelSpectrumResults, m_savedModelContinuumFittingResults seems unused ?


 Comments   
Comment by Redmine-Jira Migtation [ 24/Aug/23 ]

Comment by Didier Vibert on 2021-06-29 09:24:50:
je rajoute un nettoyage: suppression du membre @m_savedModelContinuumFittingResults@ de la classe @CExtremaResult<TExtremaResult>@
(redondant avec le templating de CExtremaResult)

Comment by Redmine-Jira Migtation [ 24/Aug/23 ]

Comment by Didier Vibert on 2021-07-20 12:30:23:
added a few points to the description

Generated at Sat Feb 10 15:30:33 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.