[REDMINE1D-189] [RM-8156] [linemodel templatefitting fft] study the minimal number of redshift points needed to activate fftprocessing Created: 05/Jul/23  Updated: 05/Jul/23

Status: Open
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2023-06-29 09:00:52 by Didier Vibert. % Done: 0

The cpu time gain of fftprocessing for template fitting is depending on the number of redshfit samples: when this number is too small the gain may actually be a loss !

Thus a minimal number of z-points have been hard-coded for the templatefitting in the linemodel, (which is mostly relevant for the linemodel second pass, where the z-points are only those of the second pass redshift window).
The hard-coding is here, in the code source:
https://gitlab.lam.fr/CPF/cpf-redshift/-/blob/0.42.0/RedshiftLibrary/src/lib/operator/linemodel.cpp#L236

The trick is that this minimal z-points number is also depending on the number of samples in the spectrum, thus it could be expressed as a % of the number of spectrum samples.

TODO:

  • set this minimal number as a parameter, expressed as a % of the number of spectral samples (use the log-sampled spectra, ie without holes)
  • study the performance impact for several values of the parameter and spectrum size, to deduce a typical value for this new param

Generated at Sat Feb 10 15:30:12 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.