[REDMINE1D-18] [RM-6447] first pass results are wrong Created: 04/Jun/21  Updated: 13/Jun/23  Resolved: 13/Jun/23

Status: Done
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2021-04-14 07:24:06 by Didier Vibert. % Done: 100

when dealing with #6340 I have seen a bug in the way the hdf5 outputs are getting the first pass results. These results are in the resultstore, but the global @COperatorResultStore::getCandidateData@ which are calling the derived function on each result is wrong for the first pass results. There are taken from the final result @linemodel_extrema@ in the resulstore instead of the first pass results (@linemodel_firstpass_extrema@) and are thus equal to 2nd pass results).

we can either:

  • correct for this right now ( the fix seems easy, since all the 1st pass hdf5 attributes have their name beginning with the string "FirstPass" we can check for this in @COperatorResultStore::getCandidateData@ and call the derived @getCandidateData@ on the correct result (@linemodel_firstpass_extrema@)
  • wait for #6343


 Comments   
Comment by yuki.moritani [ 13/Jun/23 ]

Comment by Didier Vibert on 2021-09-03 12:41:58:
corrected in release 0.24

first pass results are not anymore in the resultStore

there is a dedicated issue for reintroducing them (#6091)

Generated at Sat Feb 10 15:28:27 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.