[REDMINE1D-16] [RM-6459] template ratio ism extinction should not be applied to amplitude of absorption lines... Created: 04/Jun/21  Updated: 10/Feb/24

Status: Review Complete
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2021-04-16 16:37:15 by Didier Vibert. % Done: 100

amplitude of absorption lines are unitless coefficient in [0,1] and the effective spectral profile is

s(lamda) = C(lambda)*(1-a)*LineProfile(lambda) where C(lambda) is the continuum, a is the fitted absorption amplitude and LineProfile is a normalized profile with maximum at 1.

Thus the extinction of the continuum is operating on the absorptions lines, and it should not be applied a second time on the amplitude a. The current code for template ratio currently multiply the amplitude by the extinction low. It should not.



 Comments   
Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Didier Vibert on 2024-01-12 16:54:48:
I let it in planif, I anticipate not too much conflict with #6028

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Didier Vibert on 2024-01-16 16:09:33:
dans un premier temps, on se contente de modifier @CLineCatalogsTplRatio::InitLineCorrespondingAmplitudes@ pour que les amplitudes de l'élement en absorption ne soient pas modifiée par l'ism.

dans un deuxième temps, on peut effectuer un refacto (un peu plus complexe) pour éviter de refitter l'élement en abs pour les ratios identiques correspondant à un index ism qui change.

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Gaelle Daste on 2024-01-26 12:25:06:
Voici les ITs full comparés avec develop :
/net/CESAM/amazed/gdaste/tests/fix_issue_6459

Ca concerne le point "dans un premier temps" de ta note

MR : https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/578

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Didier Vibert on 2024-02-01 14:13:37:
@gdaste stp tu peux créer un ticket pour traiter le refacto proposé dans un "deuxième temps" #note-15 si on ne le traite pas ici. merci

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Didier Vibert on 2024-02-01 15:25:36:
ok pour le code. Dis-moi dès que tu as les IT que je regarde avant de passer en feedback

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Gaelle Daste on 2024-02-02 10:29:01:
ITs full après la dernière modif : /net/CESAM/amazed/gdaste/tests/fix_issue_6459

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Didier Vibert on 2024-02-05 15:04:23:
Gaelle Daste wrote in #note-22:
> ITs full après la dernière modif : /net/CESAM/amazed/gdaste/tests/fix_issue_6459

ok c'est bon.

Comment by Redmine-Jira Migtation [ 10/Feb/24 ]

Comment by Pierre-yves Chabaud on 2024-02-09 14:06:52:
Merged into @develop@ (@5ad7c2d0@)

Generated at Sat Feb 10 15:28:26 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.