[REDMINE1D-155] [RM-7040] [linemodel] modify the hard-coded specific line identification Created: 13/Jun/23  Updated: 15/Jun/23

Status: Open
Project: 1D Redmine
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Redmine-Jira Migtation Assignee: Redmine-Jira Migtation
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Created on 2022-02-03 12:02:27 by Didier Vibert. % Done: 0

Some lines have a specific treatment (Lya, Balmer rules, Ha, OII,...)
those lines are identified by their hard-coded name, which should thus be the same than the one in the linecatalog.

since the introduction of the new lines catalog format (#6856 ), and the future cleaning of the names (#7034) :

  • this identification should now be done through their internal string ID composed as <name><wavelength: 2 decimals><type: A|E>
    see calibration lib code:
    <pre><code class="python">
    def _get_linecatalog_id(self, row):
    wl = round(row.WaveLength,2)
    return row.Name + "" + str(wl) + "" + row.Type
    </code></pre>

=> this raises the question again: should we put the name in this ID ?

  • centralize these specifc line identifications in some class or enum, for easier further modifications.

Generated at Sat Feb 10 15:29:50 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.